Commit Graph

8058 Commits

Author SHA1 Message Date
Simon L.
8a9c3c4512 perf(apache): improve Apache container performance and correctness (#7959) 2026-04-20 15:58:35 +02:00
copilot-swe-agent[bot]
49a24272f6 perf(apache): improve performance of the Apache container
- nextcloud.conf: increase BrotliCompressionQuality from 0 to 4
- nextcloud.conf: add mod_deflate fallback for non-Brotli clients
- nextcloud.conf: enable HTTP/2 cleartext (h2c) via mod_http2 IfModule block
- nextcloud.conf: remove Options Indexes and duplicate Options line
- nextcloud.conf: remove deprecated Satisfy Any directive
- nextcloud.conf: add KeepAlive On / KeepAliveTimeout 5 / MaxKeepAliveRequests 100
- nextcloud.conf: add EnableSendfile On / EnableMMAP Off
- Dockerfile: enable mod_http2 LoadModule via sed
- Dockerfile: tune mpm_event (MaxRequestWorkers 400, ServerLimit 16,
  ThreadsPerChild 25, StartServers 2, MinSpareThreads 25, MaxSpareThreads 75)
- Caddyfile: add encode gzip zstd for response compression
- supervisord.conf: remove duplicate nodaemon=true

Agent-Logs-Url: https://github.com/nextcloud/all-in-one/sessions/a79198ed-cd31-4e15-9074-b3d3f3f92069

fix(apache): disable HTTP/2, disable Caddy gzip, restore MaxRequestWorkers 5000

- Caddyfile: remove `encode gzip zstd` (disable gzip/zstd compression in Caddy)
- nextcloud.conf: remove HTTP/2 `<IfModule mod_http2.c>` block (disable h2c in Apache)
- Dockerfile: remove mod_http2.so LoadModule sed line
- Dockerfile: restore MaxRequestWorkers 5000, ServerLimit 200, and original comments

Kept from previous commit:
- BrotliCompressionQuality raised from 0 to 4
- mod_deflate fallback for non-Brotli clients
- KeepAlive On / KeepAliveTimeout 5 / MaxKeepAliveRequests 100
- EnableSendfile On / EnableMMAP Off
- ThreadsPerChild 25, StartServers 2, MinSpareThreads 25, MaxSpareThreads 75
- supervisord.conf: remove duplicate nodaemon=true

Agent-Logs-Url: https://github.com/nextcloud/all-in-one/sessions/66a07d0e-2276-4b0e-b17d-53c733530d07

fix(apache): prevent double-encoding, add explanatory comments

- Add SetEnvIfNoCase Accept-Encoding \bbr\b no-gzip inside mod_brotli block
  so mod_deflate is skipped for clients that already get Brotli-compressed
  responses, preventing double-encoding.
- Expand all comments to explain the purpose/benefit of each added directive.

Agent-Logs-Url: https://github.com/nextcloud/all-in-one/sessions/98098727-e2c1-4504-b0d5-47c8b06b794d

docs(apache/Dockerfile): add explanatory comments to all new directives

- Add comment block before the sed/LoadModule block explaining why mpm_event
  is chosen and why mod_brotli is enabled alongside the deflate fallback.
- Add per-line comments for ThreadsPerChild, StartServers, MinSpareThreads,
  and MaxSpareThreads explaining the rationale for each value.

Agent-Logs-Url: https://github.com/nextcloud/all-in-one/sessions/2dc7afc9-b8a1-4b0a-ba13-0ad89e5c2d37

fix(apache): disable EnableSendfile to allow output filters (Brotli/deflate) on static files

Agent-Logs-Url: https://github.com/nextcloud/all-in-one/sessions/54995b4a-7b5d-4e8e-a92a-684d32b42bd4

docs(apache/nextcloud.conf): add per-directive comments to KeepAlive block

Agent-Logs-Url: https://github.com/nextcloud/all-in-one/sessions/329da0e6-b5dd-4cdd-8c05-9ae0bf25ebfd

reduce MaxSpareThreads from 75 to 50

Agent-Logs-Url: https://github.com/nextcloud/all-in-one/sessions/f253e0c7-a192-4bda-96c2-c12a7e1cb81b

raise MaxKeepAliveRequests from 100 to 500 for Nextcloud sync clients

Agent-Logs-Url: https://github.com/nextcloud/all-in-one/sessions/89da74d6-b0d3-4d19-909d-dee06cbad060

remove deflate fallback — all Nextcloud-supported browsers have Brotli

Agent-Logs-Url: https://github.com/nextcloud/all-in-one/sessions/def9ae64-6793-4c8f-ba0c-e36ef6f8f28f

Apply suggestion from @szaimen

Signed-off-by: Simon L. <szaimen@e.mail.de>
Co-Authored-By: szaimen <42591237+szaimen@users.noreply.github.com>
2026-04-20 15:57:02 +02:00
Simon L.
7bae058dbe nextcloud: switch PHP-FPM to dynamic mode and add max_requests to recycle stale workers (#7969) 2026-04-20 15:38:55 +02:00
copilot-swe-agent[bot]
66236c1a2e nextcloud: switch PHP-FPM to dynamic mode and add max_requests to recycle stale workers
Agent-Logs-Url: https://github.com/nextcloud/all-in-one/sessions/29135c39-9a45-49bd-85fe-8d3eea344450

Signed-off-by: Simon L. <szaimen@e.mail.de>

docs: add per-setting inline comments to PHP-FPM sed block in Dockerfile

Agent-Logs-Url: https://github.com/nextcloud/all-in-one/sessions/398bb2f7-e5be-4ffc-942a-7ab10dbaa1be
Co-Authored-By: szaimen <42591237+szaimen@users.noreply.github.com>
2026-04-20 15:37:39 +02:00
Simon L.
091fb8e814 aio-interface: cache reads from GetDailyBackupTimeFile based on mtime (#7957) 2026-04-20 14:58:21 +02:00
copilot-swe-agent[bot]
ee4088744c aio-interface: cache reads from GetDailyBackupTimeFile based on mtime
Agent-Logs-Url: https://github.com/nextcloud/all-in-one/sessions/01d18358-7a1e-4747-85f5-3f002aa59253

aio-interface: cache reads from GetDailyBackupTimeFile based on mtime

Agent-Logs-Url: https://github.com/nextcloud/all-in-one/sessions/4df5e1bd-456d-4005-8432-4e9b537c8e54

fix: set dailyBackupFileMtime default to 0 instead of null

Agent-Logs-Url: https://github.com/nextcloud/all-in-one/sessions/ba492f66-d5f0-450f-b0e1-658806bf070d

fix: restore missing closing brace of deleteDailyBackupTime

Agent-Logs-Url: https://github.com/nextcloud/all-in-one/sessions/6e5fb177-9754-4b64-8e93-b5be989f5162
Co-Authored-By: szaimen <42591237+szaimen@users.noreply.github.com>
2026-04-20 14:50:46 +02:00
Simon L.
ac38ea38b7 talk container update (#7968) 2026-04-20 14:29:21 +02:00
Simon L.
ada407751a PHP dependency updates (#7967) 2026-04-20 14:29:11 +02:00
Simon L.
845d08ba09 perf(postgresql): tune PostgreSQL settings for improved Nextcloud performance (#7944) 2026-04-20 14:26:11 +02:00
szaimen
65a3244a2f talk-update automated change
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2026-04-20 12:22:52 +00:00
Simon L.
7c8433d07a feat: improve Redis container performance (#7948) 2026-04-20 14:22:45 +02:00
Simon L.
7e628b1200 perf(nextcloud): tune OPcache, APCu, realpath_cache, output_buffering, and Redis session settings (#7946) 2026-04-20 14:21:36 +02:00
szaimen
8ebd624aa8 php dependency updates
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2026-04-20 12:20:28 +00:00
copilot-swe-agent[bot]
fceec6f23e feat: improve Redis container performance
- Disable RDB persistence (--save "") since Redis is used as a pure
  cache and lock store; snapshotting causes fork/CoW pressure and I/O spikes
- Set --maxmemory-policy allkeys-lru to enable LRU eviction and prevent
  unbounded memory growth
- Enable lazyfree background deletions (--lazyfree-lazy-*) to move key
  eviction, expiry, and DEL operations off the main event loop thread
- Enable active memory defragmentation (--activedefrag yes) for long-running
  instances
- Increase background task frequency to --hz 15 for faster key expiry
- Add Transparent Huge Pages (THP) startup warning, consistent with the
  existing vm.overcommit_memory check
- Refactor start.sh to build arguments via a bash array, avoiding eval
  and safely handling the empty-string --save "" and the password argument
- Remove the pre-existing unreachable exec "$@" at the end of start.sh
- Add timeout and read_timeout (1.5s) to standalone Redis config in
  redis.config.php to prevent PHP workers from hanging indefinitely

Agent-Logs-Url: https://github.com/nextcloud/all-in-one/sessions/e68c1986-419f-49b4-9cd0-c1f0efda0351
Co-Authored-By: Simon L. <szaimen@e.mail.de>
Co-Authored-By: szaimen <42591237+szaimen@users.noreply.github.com>
2026-04-20 14:20:27 +02:00
Simon L.
ff86c6d066 perf(fulltextsearch): improve elasticsearch healthcheck and add performance tuning (#7947) 2026-04-20 14:11:20 +02:00
Simon L.
ed672fb99c ContainerDefinitionFetcher: cache the containers.json in apcu (#7951) 2026-04-20 14:09:04 +02:00
Simon L.
ef87e82f13 talk: improve startup ordering, NATS tuning, signaling timeouts, and healthcheck depth (#7945) 2026-04-20 14:01:49 +02:00
copilot-swe-agent[bot]
144c91ae02 ContainerDefinitionFetcher: cache the containers.json in apcu
Agent-Logs-Url: https://github.com/nextcloud/all-in-one/sessions/b8bc4ea2-eee0-4e3f-bd71-d1c5a38c93e9

perf: set apc.shm_size=32M explicitly in mastercontainer Dockerfile

Agent-Logs-Url: https://github.com/nextcloud/all-in-one/sessions/4af50c77-4ac1-4947-9b35-dc66d0d0cc8b

perf: revert all previous changes; cache containers.json in APCu

Agent-Logs-Url: https://github.com/nextcloud/all-in-one/sessions/59281e92-7e5d-40ef-a152-78e0620eb949

perf: address review comments - clarify cache comment, restore readonly constructors

Agent-Logs-Url: https://github.com/nextcloud/all-in-one/sessions/b8bc4ea2-eee0-4e3f-bd71-d1c5a38c93e9
Co-Authored-By: szaimen <42591237+szaimen@users.noreply.github.com>
2026-04-20 13:59:51 +02:00
copilot-swe-agent[bot]
5ead361c04 talk: improve startup ordering, NATS tuning, signaling timeouts, and healthcheck depth
Agent-Logs-Url: https://github.com/nextcloud/all-in-one/sessions/7fd39619-0f63-494c-902c-746f00d17d02
Co-Authored-By: szaimen <42591237+szaimen@users.noreply.github.com>
Signed-off-by: Simon L. <szaimen@e.mail.de>
2026-04-20 13:58:56 +02:00
Simon L.
2b5998e57d aio-interface: enable PHP OPcache and Twig template cache (#7950) 2026-04-20 13:55:33 +02:00
copilot-swe-agent[bot]
3c17a6af36 aio-interface: enable PHP OPcache and Twig template cache
Agent-Logs-Url: https://github.com/nextcloud/all-in-one/sessions/2d974f3d-5f37-47e9-aa1f-00a43bcd9838
Signed-off-by: Simon L. <szaimen@e.mail.de>
Co-Authored-By: szaimen <42591237+szaimen@users.noreply.github.com>
Signed-off-by: Simon L. <szaimen@e.mail.de>
2026-04-20 13:47:59 +02:00
Simon L.
a465baa259 aio-interface: Complete Permissions-Policy header with all MDN-listed directives (#7953) 2026-04-20 13:40:31 +02:00
Simon L.
457f7bfee9 imaginary: improve healthcheck and start.sh (#7949) 2026-04-20 13:40:19 +02:00
copilot-swe-agent[bot]
aade77437c imaginary: improve healthcheck and start.sh
Co-Authored-By: szaimen <42591237+szaimen@users.noreply.github.com>
2026-04-20 13:30:53 +02:00
Simon L.
ccda322888 aio-interface: combine all disable-*.js files into a single disable-containers.js (#7958) 2026-04-20 13:24:50 +02:00
Simon L.
c428bc3b71 aio-interface: preserve login session across container restarts after cookie name change (#7964) 2026-04-20 13:23:38 +02:00
copilot-swe-agent[bot]
479f68d69e aio-interface: combine all disable-*.js files into disable-containers.js
Agent-Logs-Url: https://github.com/nextcloud/all-in-one/sessions/a5859e89-d042-4dd5-82e9-9ceed4e22c70
Co-Authored-By: szaimen <42591237+szaimen@users.noreply.github.com>
Signed-off-by: Simon L. <szaimen@e.mail.de>
2026-04-20 13:15:46 +02:00
Simon L.
e1ae6444e5 increase version of click-handlers
Signed-off-by: Simon L. <szaimen@e.mail.de>
2026-04-20 13:08:47 +02:00
Simon L.
47ee453719 aio-interface: correct variable shadowing in show-password event handler (#7963) 2026-04-20 13:08:08 +02:00
copilot-swe-agent[bot]
e378f7faca aio-interface: preserve login session across container restarts after cookie name change
The session cookie was recently renamed from `PHPSESSID` to
   `__Host-Http-PHPSESSID` (commit 3871179a). When watchtower updates the
   mastercontainer, the browser still holds the old `PHPSESSID` cookie, but the
   new code only looks for `__Host-Http-PHPSESSID`. The old cookie is ignored, a
   fresh unauthenticated session is created, and the user is logged out.

   Fix: before starting the new session in index.php, check if the old `PHPSESSID`
   cookie exists and carries an authenticated session. If it does, destroy the old
   session and mark the new one as authenticated via `SetAuthState(true)`.

Agent-Logs-Url: https://github.com/nextcloud/all-in-one/sessions/cba0ea31-e257-4ec1-82ae-dd66f0f34d98

---

refactor: address review comments - use constant for session key and activity interval

Agent-Logs-Url: https://github.com/nextcloud/all-in-one/sessions/cba0ea31-e257-4ec1-82ae-dd66f0f34d98
Co-Authored-By: szaimen <42591237+szaimen@users.noreply.github.com>
2026-04-20 13:05:41 +02:00
copilot-swe-agent[bot]
4679c6c38d fix: correct variable shadowing in show-password event handler
Agent-Logs-Url: https://github.com/nextcloud/all-in-one/sessions/1927b3c2-7484-4876-b037-79d94f2ecb6a

Co-authored-by: szaimen <42591237+szaimen@users.noreply.github.com>
2026-04-20 10:09:04 +00:00
Simon L.
91e9e58c39 jellyfin: allow Jellyfin to resolve lldap hostname while running in host network mode (#7941) 2026-04-20 11:42:19 +02:00
Simon L.
5624dde376 alpine: fix labels
Signed-off-by: Simon L. <szaimen@e.mail.de>
2026-04-20 11:32:33 +02:00
copilot-swe-agent[bot]
d0b0bde4c8 jellyfin: allow Jellyfin to resolve lldap hostname while running in host network mode
Agent-Logs-Url: https://github.com/nextcloud/all-in-one/sessions/3bd90eb7-e6f2-4647-9e78-4f9349300a29

fix: use gethostbyname for lldap IP and fix community-container depends_on skip logic

Agent-Logs-Url: https://github.com/nextcloud/all-in-one/sessions/67d6ed5f-8bdc-4b9b-a33c-9ff73305c799

fix: ensure lldap starts before jellyfin via depends_on

Agent-Logs-Url: https://github.com/nextcloud/all-in-one/sessions/448ec7d3-f71e-4499-a4a4-67314434a77c

Update ContainerDefinitionFetcher.php

Signed-off-by: Simon L. <szaimen@e.mail.de>

fix: protect standard container dependencies from being skipped for community containers

Agent-Logs-Url: https://github.com/nextcloud/all-in-one/sessions/cdd6a51b-75a3-4f43-9d00-85b1df2f880f
Co-Authored-By: szaimen <42591237+szaimen@users.noreply.github.com>
2026-04-20 11:22:24 +02:00
copilot-swe-agent[bot]
310429c5fd fix: add shm_size=128M to nextcloud container to match apc.shm_size
Agent-Logs-Url: https://github.com/nextcloud/all-in-one/sessions/0b44e4a1-dccc-4541-b4cb-07fceaa046ca

Co-authored-by: szaimen <42591237+szaimen@users.noreply.github.com>
2026-04-19 22:03:09 +00:00
copilot-swe-agent[bot]
98a8861690 Add missing Permissions-Policy directives to headers.Caddyfile
Agent-Logs-Url: https://github.com/nextcloud/all-in-one/sessions/5735ef2f-5264-43ad-a107-433f2770d05f

Co-authored-by: szaimen <42591237+szaimen@users.noreply.github.com>
2026-04-18 10:53:10 +00:00
Simon L.
d2ecff2e06 aio-interface: offer system prune button (#7677) 2026-04-18 12:08:01 +02:00
copilot-swe-agent[bot]
29bac9dbf9 fix(fulltextsearch): clarify healthcheck to explicitly accept green/yellow cluster status
Use filter_path=status to get a minimal JSON response and explicitly match
only green or yellow status (single-node clusters run yellow by design).
This is clearer and more robust than the inverted grep approach.

Agent-Logs-Url: https://github.com/nextcloud/all-in-one/sessions/a036678d-a9f5-4db3-8cc6-3e3d52f4e97f

Co-authored-by: szaimen <42591237+szaimen@users.noreply.github.com>
2026-04-17 15:36:26 +00:00
copilot-swe-agent[bot]
7cd0450dae perf(nextcloud): tune OPcache, APCu, realpath_cache, output_buffering, and Redis session settings
Agent-Logs-Url: https://github.com/nextcloud/all-in-one/sessions/623eef77-7b4e-428b-b06f-e0c7403f8cf6

Co-authored-by: szaimen <42591237+szaimen@users.noreply.github.com>
2026-04-17 15:36:12 +00:00
copilot-swe-agent[bot]
b5dad7927a perf(fulltextsearch): improve elasticsearch healthcheck and add performance tuning settings
- Replace TCP-only nc healthcheck with HTTP cluster health API check via curl,
  so the container is only marked healthy when ES is actually ready (not just
  when the TCP port is open during startup)
- Add indices.fielddata.cache.size=20% to cap field-data cache and prevent
  unbounded heap growth / OOM kills on large datasets
- Add indices.memory.index_buffer_size=20% to improve bulk indexing throughput
  by buffering more data in memory before flushing to disk
- Add thread_pool.write.queue_size=1000 to avoid rejected indexing requests
  when Nextcloud's background jobs submit many files simultaneously

Changes applied to: Containers/fulltextsearch/healthcheck.sh,
php/containers.json, manual-install/latest.yml

Agent-Logs-Url: https://github.com/nextcloud/all-in-one/sessions/a036678d-a9f5-4db3-8cc6-3e3d52f4e97f

Co-authored-by: szaimen <42591237+szaimen@users.noreply.github.com>
2026-04-17 15:35:13 +00:00
copilot-swe-agent[bot]
fcc4d9502d docs(postgresql): clarify work_mem memory allocation semantics in comment
Agent-Logs-Url: https://github.com/nextcloud/all-in-one/sessions/0456b491-e148-4d26-9dc9-e1df9bfbf5d0

Co-authored-by: szaimen <42591237+szaimen@users.noreply.github.com>
2026-04-17 15:34:43 +00:00
Simon L.
ebca410220 Merge pull request #7943 from nextcloud/copilot/improve-collabora-container-performance
collabora: Add shm_size and tmpfs to improve the performance
2026-04-17 17:34:30 +02:00
copilot-swe-agent[bot]
80ea0c1151 perf(postgresql): tune postgres settings for improved Nextcloud performance
- shared_buffers: 128MB → 256MB (better hot-data caching)
- effective_cache_size: set to 1GB (planner hint, no memory allocated)
- work_mem: 4MB → 16MB (reduces disk spills in file listing / share queries)
- maintenance_work_mem: 64MB → 256MB (faster VACUUM and index builds)
- wal_buffers: auto → 16MB (reduces WAL write latency)
- checkpoint_timeout: 5min → 15min (spreads checkpoint I/O, reduces spikes)
- random_page_cost: 4.0 → 1.1 (SSD-appropriate; favours index scans)
- effective_io_concurrency: 1 → 200 (SSD-appropriate I/O prefetching)
- autovacuum_vacuum_scale_factor: 0.2 → 0.05 (vacuum sooner on large tables)
- autovacuum_analyze_scale_factor: 0.1 → 0.02 (keep planner stats fresh)

All changes are applied via sed in the existing postgresql.conf modification
block and are idempotent across container restarts (handles both commented
defaults on fresh installs and already-set values on restart).

Agent-Logs-Url: https://github.com/nextcloud/all-in-one/sessions/0456b491-e148-4d26-9dc9-e1df9bfbf5d0

Co-authored-by: szaimen <42591237+szaimen@users.noreply.github.com>
2026-04-17 15:33:46 +00:00
Simon L.
56462e7945 Merge pull request #7942 from nextcloud/copilot/adjust-headers-caddyfile
aio-interface: Add Permissions-Policy header
2026-04-17 17:13:34 +02:00
copilot-swe-agent[bot]
8dea787518 Add shm_size and tmpfs to collabora container for performance improvement
Agent-Logs-Url: https://github.com/nextcloud/all-in-one/sessions/352eb94e-be98-422a-96d9-39da7e4443cd

Co-authored-by: szaimen <42591237+szaimen@users.noreply.github.com>
2026-04-17 15:04:58 +00:00
Simon L.
60c3515870 Merge pull request #7940 from nextcloud/copilot/remove-collabora-warning-docs
docker-rootles.md: Remove outdated Collabora warning
2026-04-17 16:58:14 +02:00
copilot-swe-agent[bot]
fed426b635 Add Permissions-Policy header to headers.Caddyfile
Agent-Logs-Url: https://github.com/nextcloud/all-in-one/sessions/8ef03112-cdc4-46d1-b1f1-96c2a85e92c0

Co-authored-by: szaimen <42591237+szaimen@users.noreply.github.com>
2026-04-17 14:45:12 +00:00
copilot-swe-agent[bot]
f15b32c758 Remove outdated Collabora warning from docker-rootless.md
Agent-Logs-Url: https://github.com/nextcloud/all-in-one/sessions/3dcfae77-d290-4a68-bf70-50ca6e4ad75a

Co-authored-by: szaimen <42591237+szaimen@users.noreply.github.com>
2026-04-17 14:43:39 +00:00
Simon L.
f25f588295 aio-interface: offer system prune button
Signed-off-by: Simon L. <szaimen@e.mail.de>
Co-Authored-By: szaimen <42591237+szaimen@users.noreply.github.com>
Co-Authored-By: Pablo Zmdl <57864086+pabzm@users.noreply.github.com>
Signed-off-by: Simon L. <szaimen@e.mail.de>
2026-04-17 14:33:53 +02:00
Simon L.
cbdd75d668 Merge pull request #7934 from nextcloud/rp-npm-npmplus
rp-docs: update reverse proxy docs for NPM and NPMplus
2026-04-17 14:21:15 +02:00