daenamnu/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/all-in-one.git synced 2026-06-10 08:37:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(ci): use playwright binary directly instead of npx to prevent hang

Browse Source 
The npx/npm-exec process wrapper can fail to detect child process exit,
causing indefinite hangs. Calling node_modules/.bin/playwright directly
bypasses the npm process management layer entirely.
This commit is contained in:
copilot-swe-agent[bot]
2026-06-02 14:59:57 +00:00
committed by GitHub
parent 5c84df6149
commit 91a7024bc6
2 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.github/workflows/playwright-on-push.yml
+4 -4
View File
@@ -38,10 +38,10 @@ jobs:
run: cd php/tests && npm ci run: cd php/tests && npm ci
- name: Install Playwright system dependencies - name: Install Playwright system dependencies
run: cd php/tests && npx playwright install-deps chromium run: cd php/tests && ./node_modules/.bin/playwright install-deps chromium
- name: Install Playwright Browsers - name: Install Playwright Browsers
run: cd php/tests && npx playwright install chromium run: cd php/tests && ./node_modules/.bin/playwright install chromium
- name: Set up php 8.5 - name: Set up php 8.5
uses: shivammathur/setup-php@accd6127cb78bee3e8082180cb391013d204ef9f # v2.37.0 uses: shivammathur/setup-php@accd6127cb78bee3e8082180cb391013d204ef9f # v2.37.0
@@ -89,7 +89,7 @@ jobs:
run: | run: |
cd php/tests cd php/tests
export DEBUG=pw:api export DEBUG=pw:api
if ! npx playwright test tests/initial-setup.spec.js; then if ! ./node_modules/.bin/playwright test tests/initial-setup.spec.js; then
docker logs nextcloud-aio-mastercontainer docker logs nextcloud-aio-mastercontainer
docker logs nextcloud-aio-borgbackup docker logs nextcloud-aio-borgbackup
exit 1 exit 1
@@ -121,7 +121,7 @@ jobs:
run: | run: |
cd php/tests cd php/tests
export DEBUG=pw:api export DEBUG=pw:api
if ! npx playwright test tests/restore-instance.spec.js; then if ! ./node_modules/.bin/playwright test tests/restore-instance.spec.js; then
docker logs nextcloud-aio-mastercontainer docker logs nextcloud-aio-mastercontainer
docker logs nextcloud-aio-borgbackup docker logs nextcloud-aio-borgbackup
exit 1 exit 1
.github/workflows/playwright-on-workflow-dispatch.yml
+4 -4
View File
@@ -23,10 +23,10 @@ jobs:
run: cd php/tests && npm ci run: cd php/tests && npm ci
- name: Install Playwright system dependencies - name: Install Playwright system dependencies
run: cd php/tests && npx playwright install-deps chromium run: cd php/tests && ./node_modules/.bin/playwright install-deps chromium
- name: Install Playwright Browsers - name: Install Playwright Browsers
run: cd php/tests && npx playwright install chromium run: cd php/tests && ./node_modules/.bin/playwright install chromium
- name: Start fresh development server - name: Start fresh development server
run: | run: |
@@ -51,7 +51,7 @@ jobs:
run: | run: |
cd php/tests cd php/tests
export DEBUG=pw:api export DEBUG=pw:api
if ! npx playwright test tests/initial-setup.spec.js; then if ! ./node_modules/.bin/playwright test tests/initial-setup.spec.js; then
docker logs nextcloud-aio-mastercontainer docker logs nextcloud-aio-mastercontainer
docker logs nextcloud-aio-borgbackup docker logs nextcloud-aio-borgbackup
exit 1 exit 1
@@ -79,7 +79,7 @@ jobs:
run: | run: |
cd php/tests cd php/tests
export DEBUG=pw:api export DEBUG=pw:api
if ! npx playwright test tests/restore-instance.spec.js; then if ! ./node_modules/.bin/playwright test tests/restore-instance.spec.js; then
docker logs nextcloud-aio-mastercontainer docker logs nextcloud-aio-mastercontainer
docker logs nextcloud-aio-borgbackup docker logs nextcloud-aio-borgbackup
exit 1 exit 1