From 91a7024bc6f40b4c00ab77d903e964ea25e37638 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Tue, 2 Jun 2026 14:59:57 +0000 Subject: [PATCH] fix(ci): use playwright binary directly instead of npx to prevent hang The npx/npm-exec process wrapper can fail to detect child process exit, causing indefinite hangs. Calling node_modules/.bin/playwright directly bypasses the npm process management layer entirely. --- .github/workflows/playwright-on-push.yml | 8 ++++---- .github/workflows/playwright-on-workflow-dispatch.yml | 8 ++++---- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/.github/workflows/playwright-on-push.yml b/.github/workflows/playwright-on-push.yml index 8ebf8b60..1e7d3d80 100644 --- a/.github/workflows/playwright-on-push.yml +++ b/.github/workflows/playwright-on-push.yml @@ -38,10 +38,10 @@ jobs: run: cd php/tests && npm ci - name: Install Playwright system dependencies - run: cd php/tests && npx playwright install-deps chromium + run: cd php/tests && ./node_modules/.bin/playwright install-deps chromium - name: Install Playwright Browsers - run: cd php/tests && npx playwright install chromium + run: cd php/tests && ./node_modules/.bin/playwright install chromium - name: Set up php 8.5 uses: shivammathur/setup-php@accd6127cb78bee3e8082180cb391013d204ef9f # v2.37.0 @@ -89,7 +89,7 @@ jobs: run: | cd php/tests export DEBUG=pw:api - if ! npx playwright test tests/initial-setup.spec.js; then + if ! ./node_modules/.bin/playwright test tests/initial-setup.spec.js; then docker logs nextcloud-aio-mastercontainer docker logs nextcloud-aio-borgbackup exit 1 @@ -121,7 +121,7 @@ jobs: run: | cd php/tests export DEBUG=pw:api - if ! npx playwright test tests/restore-instance.spec.js; then + if ! ./node_modules/.bin/playwright test tests/restore-instance.spec.js; then docker logs nextcloud-aio-mastercontainer docker logs nextcloud-aio-borgbackup exit 1 diff --git a/.github/workflows/playwright-on-workflow-dispatch.yml b/.github/workflows/playwright-on-workflow-dispatch.yml index a1a4ff43..8f1298b1 100644 --- a/.github/workflows/playwright-on-workflow-dispatch.yml +++ b/.github/workflows/playwright-on-workflow-dispatch.yml @@ -23,10 +23,10 @@ jobs: run: cd php/tests && npm ci - name: Install Playwright system dependencies - run: cd php/tests && npx playwright install-deps chromium + run: cd php/tests && ./node_modules/.bin/playwright install-deps chromium - name: Install Playwright Browsers - run: cd php/tests && npx playwright install chromium + run: cd php/tests && ./node_modules/.bin/playwright install chromium - name: Start fresh development server run: | @@ -51,7 +51,7 @@ jobs: run: | cd php/tests export DEBUG=pw:api - if ! npx playwright test tests/initial-setup.spec.js; then + if ! ./node_modules/.bin/playwright test tests/initial-setup.spec.js; then docker logs nextcloud-aio-mastercontainer docker logs nextcloud-aio-borgbackup exit 1 @@ -79,7 +79,7 @@ jobs: run: | cd php/tests export DEBUG=pw:api - if ! npx playwright test tests/restore-instance.spec.js; then + if ! ./node_modules/.bin/playwright test tests/restore-instance.spec.js; then docker logs nextcloud-aio-mastercontainer docker logs nextcloud-aio-borgbackup exit 1