Copilot
fc4bb548a4
* Fix: prevent nginx proxy read timeout from blocking AIO container startup When AIO runs behind an nginx reverse proxy and a user clicks Start, image pulls produce no streaming output for minutes at a time. nginx's proxy_read_timeout fires, drops the upstream connection, and PHP then aborts on the next write attempt (ignore_user_abort defaults to false), leaving all containers after the first one never started. Two fixes: 1. startStreamingResponse(): add ignore_user_abort(true) so PHP never terminates if the connection is already gone. 2. PullImage(): stream the Docker NDJSON pull response and write a "Pulling image" heartbeat at most once every 5 s, keeping the nginx connection alive. Also surfaces Docker-level stream errors that the old buffered call silently ignored, guards against malformed newline-free responses with a 1 MB buffer limit, and unifies the duplicate catch-block retry logic. Agent-Logs-Url: https://github.com/nextcloud/all-in-one/sessions/4fd13605-63fb-4693-8a95-89ccec31f7d3 Co-authored-by: szaimen <42591237+szaimen@users.noreply.github.com> * As heartbeat send a dot regularly Rather than repeating the message, send a "magic" dot, which gets appended to the previous line. Previously the heartbeats weren't sent regulary because reading the data into a buffer caused a lag. Signed-off-by: Pablo Zmdl <pablo@nextcloud.com> * Remove left-over constants Signed-off-by: Pablo Zmdl <pablo@nextcloud.com> * Reduce timeout to stay within nginx's default timeout of 5s Signed-off-by: Pablo Zmdl <pablo@nextcloud.com> * Fix duplicated library namespace inclusion Signed-off-by: Pablo Zmdl <pablo@nextcloud.com> * Deal with preg_replace possibly returning null Signed-off-by: Pablo Zmdl <pablo@nextcloud.com> * update the version tag Signed-off-by: Simon L. <szaimen@e.mail.de> --------- Signed-off-by: Pablo Zmdl <pablo@nextcloud.com> Signed-off-by: Simon L. <szaimen@e.mail.de> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: szaimen <42591237+szaimen@users.noreply.github.com> Co-authored-by: Pablo Zmdl <pablo@nextcloud.com> Co-authored-by: Simon L. <szaimen@e.mail.de>
PHP Docker Controller
This is the code for the PHP Docker controller.
How to run
Running this locally requires :
1. Install the development environment
This project uses Composer as dependency management software. It is very similar to NPM. The command to install all dependencies is:
composer install
2. Access to docker socket
The root user has all privileges including access to the Docker socket.
But it is not recommended to launch the local instance with full privileges, consider the docker group for docker access without being root.
See https://docs.docker.com/engine/install/linux-postinstall/#manage-docker-as-a-non-root-user
3. Run a nextcloud-aio-mastercontainer container
This application manages containers, including its own container.
So you need to run a nextcloud-aio-mastercontainer container for the application to work properly.
Here is a command to quickly launch a container :
docker run \
--rm \
--name nextcloud-aio-mastercontainer \
--volume nextcloud_aio_mastercontainer:/mnt/docker-aio-config \
--volume /var/run/docker.sock:/var/run/docker.sock \
ghcr.io/nextcloud-releases/all-in-one:latest
4. Start your server
With this command you will launch the server:
# Make sure to launch this command with a user having access to the docker socket.
SKIP_DOMAIN_VALIDATION=true composer run dev
You can then access the web interface at http://localhost:8080.
Note: You can restart the server by preceding the command with other environment variables.
Composer routine
| Command | Description |
|---|---|
composer run dev |
Starts the development server |
composer run psalm |
Run Psalm static analysis |
composer run psalm:strict |
Run Psalm static analysis strict |
composer run psalm:update-baseline |
Run Psalm with --update-baseline arg |
composer run lint |
Run PHP Syntax check |
composer run lint:twig |
Run Twig Syntax check |
composer run php-deprecation-detector |
Run PHP Deprecation Detector |