Compare commits

..

1 Commits

Author SHA1 Message Date
tobiasKaminsky 13e0842cff Previously the mapping was just $this->installLatestMajor ? 'yes' : '', so a stored value of 'no' was truthy and would have been turned into INSTALL_LATEST_MAJOR=yes in the Nextcloud container — the opposite of what the user intended. Now both ''
and 'no' result in an empty env value, which the entrypoint's [ "$INSTALL_LATEST_MAJOR" = yes ] check treats as disabled, while any other value (e.g. the '34' set by the start button or upgrade button) still maps to yes.

  Assisted-by: Claude
2026-06-12 14:35:40 +02:00
3 changed files with 3 additions and 3 deletions
+1 -1
View File
@@ -35,7 +35,7 @@ jobs:
node-version: 24.15.0 node-version: 24.15.0
- name: Install dependencies - name: Install dependencies
run: cd php/tests && npm ci --omit=optional run: cd php/tests && npm ci
- name: Install Playwright Browsers - name: Install Playwright Browsers
run: cd php/tests && npx playwright install --with-deps chromium run: cd php/tests && npx playwright install --with-deps chromium
@@ -20,7 +20,7 @@ jobs:
node-version: 24.15.0 node-version: 24.15.0
- name: Install dependencies - name: Install dependencies
run: cd php/tests && npm ci --omit=optional run: cd php/tests && npm ci
- name: Install Playwright Browsers - name: Install Playwright Browsers
run: cd php/tests && npx playwright install --with-deps chromium run: cd php/tests && npx playwright install --with-deps chromium
+1 -1
View File
@@ -1115,7 +1115,7 @@ class ConfigurationManager
'NEXTCLOUD_STARTUP_APPS' => $this->getNextcloudStartupApps(), 'NEXTCLOUD_STARTUP_APPS' => $this->getNextcloudStartupApps(),
'NEXTCLOUD_ADDITIONAL_APKS' => $this->nextcloudAdditionalApks, 'NEXTCLOUD_ADDITIONAL_APKS' => $this->nextcloudAdditionalApks,
'NEXTCLOUD_ADDITIONAL_PHP_EXTENSIONS' => $this->nextcloudAdditionalPhpExtensions, 'NEXTCLOUD_ADDITIONAL_PHP_EXTENSIONS' => $this->nextcloudAdditionalPhpExtensions,
'INSTALL_LATEST_MAJOR' => $this->installLatestMajor ? 'yes' : '', 'INSTALL_LATEST_MAJOR' => ($this->installLatestMajor !== '' && $this->installLatestMajor !== 'no') ? 'yes' : '',
'REMOVE_DISABLED_APPS' => $this->nextcloudKeepDisabledApps ? '' : 'yes', 'REMOVE_DISABLED_APPS' => $this->nextcloudKeepDisabledApps ? '' : 'yes',
// Allow to get local ip-address of database container which allows to talk to it even in host mode (the container that requires this needs to be started first then) // Allow to get local ip-address of database container which allows to talk to it even in host mode (the container that requires this needs to be started first then)
'AIO_DATABASE_HOST' => NetworkHelper::resolveHostname('nextcloud-aio-database'), 'AIO_DATABASE_HOST' => NetworkHelper::resolveHostname('nextcloud-aio-database'),