Commit Graph

519 Commits

Author SHA1 Message Date
Simon L. 1fdda55421 Apply suggestions from code review
Co-authored-by: Pablo Zmdl <57864086+pabzm@users.noreply.github.com>
Signed-off-by: Simon L. <szaimen@e.mail.de>
2026-06-23 14:52:05 +02:00
Simon L. 0d2ce61af3 fix(desec): only reveal the deSEC password for AIO-created accounts
The containers page showed "Reveal deSEC password" for every deSEC domain,
but when the user logs in with their own existing account AIO stores an
empty password, so the reveal exposed nothing useful. Gate the reveal on a
stored password: AIO-created accounts show the generated credentials as
before; existing accounts now just say the domain is managed via that
account and to log in at desec.io with your own password.

Also clear the stored generated password in the awaiting-verification path
when the user logs in with their own password (the email already had an
account), so a non-empty stored password reliably means "AIO generated this
account" — and report the account as not-new so no wildcard CNAME is created
on a domain the user manages themselves.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Signed-off-by: Simon L. <szaimen@e.mail.de>
2026-06-22 16:04:36 +02:00
Simon L. b5e35c90d8 move the desec template another time
Signed-off-by: Simon L. <szaimen@e.mail.de>
2026-06-22 16:04:35 +02:00
Simon L. ef7e320c61 fix(desec): keep modal markup and script with the moved entry block
The deSEC entry <details> was moved up above the domain submit form, but the
#desec-modal container and desec-modal.js were left behind inside the
skip_domain_validation block. Move them up to sit directly after the entry
block so the open button, modal, and wiring script are always rendered
together (and present even when domain validation is skipped). This restores
the modal flow the Playwright tests drive via #desec-frame.

Signed-off-by: Simon L. <szaimen@e.mail.de>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Signed-off-by: Simon L. <szaimen@e.mail.de>
2026-06-22 16:04:34 +02:00
Simon L. 64d49c1b59 move desec futher up in the containers template
Signed-off-by: Simon L. <szaimen@e.mail.de>
2026-06-22 16:04:34 +02:00
Simon L. b4e4ff8fd7 fix a detail
Signed-off-by: Simon L. <szaimen@e.mail.de>
2026-06-22 16:04:34 +02:00
Simon L. d2fbb711d2 feat(desec): surface domain notice at top, drop in-flow credentials
Hide the "Your deSEC login credentials" block during the in-flight
register/verify steps — the credentials are still shown in the dedicated
"deSEC account credentials" section once the domain is registered.

Extract the deSEC domain info/dnsmasq-caution notice into a reusable include
and also show it at the top of the initial-install flow, directly above the
"download and start containers" explanation, while keeping it in the
Community Containers section where it already appeared.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Signed-off-by: Simon L. <szaimen@e.mail.de>
2026-06-22 16:04:34 +02:00
Simon L. 454905c852 feat(desec): run registration flow in a modal iframe
Move the deSEC "register a free domain" flow out of the inline containers
page form and into a modal backed by a dedicated /desec view loaded in an
iframe. The multi-step register -> verify -> domain process now re-renders
inside the modal, so the user can adjust the details and complete email
verification without reloading the whole page each step. Only once the
domain is fully registered does the view reload the parent containers page.

- add /desec route + desec.twig standalone view
- add desec-modal.js (open/close, backdrop + Escape) and desec-done.js
  (parent reload on completion)
- redirect register POST to the /desec view so steps stay in the modal
- drop the redundant <details> wrapper in desec-register.twig, add heading
- style the modal and let <button class="button"> pick up button styles
- drive the modal iframe in the Playwright specs and update the QA checklist

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Signed-off-by: Simon L. <szaimen@e.mail.de>
2026-06-22 13:24:50 +02:00
Simon L. 1868738f56 feat(desec): add register -> verify -> domain UI
- includes/desec-register.twig renders the multi-step deSEC flow: enter email
  (optionally an existing password), the awaiting-verification step, and the
  account-registered step, with friendly messaging for the ambiguous "email
  already registered" case (deSEC returns 202 either way to prevent enumeration).
- containers.twig includes the deSEC section under the domain-entry UI; index.php
  passes the deSEC config/state (email, password, registered/awaiting flags) to
  the view.
- Move the deSEC password reveal from an inline style to a CSS class (no inline
  CSS/JS in templates) and bump the style.css cache-buster to v13 in layout.twig
  and log.twig.

Co-Authored-By: szaimen <42591237+szaimen@users.noreply.github.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Signed-off-by: Simon L. <szaimen@e.mail.de>
2026-06-18 13:19:16 +02:00
Copilot 6375921282 add eurooffice (#8052) 2026-06-04 12:42:02 +02:00
Copilot 1f94bc8af0 aio-interface: extract Nextcloud latest-major upgrade logic to dedicated script and add UI trigger button (#7988)
* Extract Nextcloud major upgrade logic to script and add UI button

Agent-Logs-Url: https://github.com/nextcloud/all-in-one/sessions/8cd11b09-5073-4e27-8e59-9afffaf96c1f

Rename sendNotification to execCommandInContainer and reuse for upgrade method

Agent-Logs-Url: https://github.com/nextcloud/all-in-one/sessions/88744552-9d64-4de2-9f64-5a98a5e3b200

Add $cmd array validation to execCommandInContainer

Agent-Logs-Url: https://github.com/nextcloud/all-in-one/sessions/45d5228c-7834-404e-ba54-90b5c8c207c8

Apply suggestion from @szaimen

Signed-off-by: Simon L. <szaimen@e.mail.de>

Apply suggestion from @szaimen

Signed-off-by: Simon L. <szaimen@e.mail.de>

Apply suggestion from @szaimen

Signed-off-by: Simon L. <szaimen@e.mail.de>

Apply suggestion from @szaimen

Signed-off-by: Simon L. <szaimen@e.mail.de>

Set installLatestMajor when upgrade-to-latest-major button is clicked

Agent-Logs-Url: https://github.com/nextcloud/all-in-one/sessions/7b977c85-9b74-4027-a536-152e49a01976

Extract getLatestMajorVersion() to avoid duplicating the version string

Agent-Logs-Url: https://github.com/nextcloud/all-in-one/sessions/d5ec921f-8629-4f6e-949a-e8f89f1eb85f

Address PR review comments and hardcode updater channel to stable

Agent-Logs-Url: https://github.com/nextcloud/all-in-one/sessions/c40941ff-2bf8-4a57-82be-2a0bd22b19a2

Restore sendNotification(), update cron files, extract getPlainStreamingCallback()

Agent-Logs-Url: https://github.com/nextcloud/all-in-one/sessions/a5b6cd86-d278-4771-8a11-976c4a862966

Remove getPlainStreamingCallback, unify on getAddToStreamingResponseBody

Agent-Logs-Url: https://github.com/nextcloud/all-in-one/sessions/15a4b815-076b-469f-95b2-c61df688a28d

Revert "Remove getPlainStreamingCallback, unify on getAddToStreamingResponseBody"

This reverts commit 6846c3a99549703121461f910cc26e6c116e0dc4.

* Refactor creating and using addToStreamingResponseBody()

This way we stick to having one implementation of the function, not three.

Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>

* Read streamed output line by line, not via buffer

This way the code doesn't wait for a buffer to be filled, and we don't need to
implement logic ourselves that is provided by a present library already.

Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>

* Ensure all HTTP requests are proxied, even with streaming

When requesting a streamed response, Guzzle apparently doesn't use curl, and thus we have to specify the unix socket proxy differently.

We can't specify it when creating the client, though (Guzzle complains).

Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>

* Fix syntax errors

Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>

* Remove broken code

Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>

* Fix readline line from streaming response

Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>

* Strip ANSI codes from command output before sending it to the browser

Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>

* Run PHP commands as www-data

Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>

* Properly compare version numbers

Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>

* Fix using memory limits from env

Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>

* Fix return type spec

This method always returns a closure, never null.

Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>

* Use more general return type

Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>

* Avoid psalm complaint

Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>

* Fix namespace of return type

Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>

* Apply suggestion from @szaimen

Signed-off-by: Simon L. <szaimen@e.mail.de>

---------

Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
Signed-off-by: Simon L. <szaimen@e.mail.de>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Pablo Zmdl <pablo@nextcloud.com>
Co-authored-by: Simon L. <szaimen@e.mail.de>
2026-06-03 12:38:50 +02:00
Simon L. 62295caa39 update link to upgrade docs
Signed-off-by: Simon L. <szaimen@e.mail.de>
2026-05-29 17:44:27 +02:00
Simon L. 2f7b98ddff preparations for the coming Hub 26 Spring release
Signed-off-by: Simon L. <szaimen@e.mail.de>
2026-05-28 11:42:03 +02:00
Simon L. 119f68b6ee aio-interface: also reset the borg backup cache when resetting the backup path (#7998) 2026-04-27 14:36:05 +02:00
Simon L. 1f813aacc3 timezone: only set the placeholder and not the value automatically because it is confusing
Signed-off-by: Simon L. <szaimen@e.mail.de>
2026-04-25 16:41:48 +02:00
copilot-swe-agent[bot] 172c72f735 aio-interface: also reset the borg backup cache when resetting the backup path
Signed-off-by: Simon L. <szaimen@e.mail.de>
2026-04-25 15:06:58 +02:00
copilot-swe-agent[bot] 4679c6c38d fix: correct variable shadowing in show-password event handler
Agent-Logs-Url: https://github.com/nextcloud/all-in-one/sessions/1927b3c2-7484-4876-b037-79d94f2ecb6a

Co-authored-by: szaimen <42591237+szaimen@users.noreply.github.com>
2026-04-20 10:09:04 +00:00
Simon L. f25f588295 aio-interface: offer system prune button
Signed-off-by: Simon L. <szaimen@e.mail.de>
Co-Authored-By: szaimen <42591237+szaimen@users.noreply.github.com>
Co-Authored-By: Pablo Zmdl <57864086+pabzm@users.noreply.github.com>
Signed-off-by: Simon L. <szaimen@e.mail.de>
2026-04-17 14:33:53 +02:00
Zoey 12e129f1f6 aio-interface: improve headers (#7690)
Signed-off-by: Zoey <zoey@z0ey.de>
Signed-off-by: Simon L. <szaimen@e.mail.de>
Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
Co-authored-by: Simon L. <szaimen@e.mail.de>
Co-authored-by: Pablo Zmdl <pablo@nextcloud.com>
2026-04-16 17:20:50 +02:00
Simon L. 99c862c2c1 aio-interface: hide Hub 26 Winter update notice
Signed-off-by: Simon L. <szaimen@e.mail.de>
2026-04-09 14:30:59 +02:00
Alan Savage 0bad0849c1 Avoid Resend popups on Firefox on start/stop containers
Use `location.reload(true)` instead of `reload` or `reload(1)`
to ensure we use a GET request.

See also:
https://stackoverflow.com/a/41122753
https://developer.mozilla.org/en-US/docs/Web/API/Location/reload#forceget

Fixes #7850

Signed-off-by: Alan Savage <3028205+asavageiv@users.noreply.github.com>
2026-04-02 10:55:25 -07:00
Simon L. 7a9bab5776 aio-interface: fix page not automatic reloading after container starting progress spinner
Signed-off-by: Simon L. <szaimen@e.mail.de>
2026-04-02 14:06:39 +02:00
Simon L. 75e18bb40a aio-interface: make Harp visible again
Signed-off-by: Simon L. <szaimen@e.mail.de>
2026-03-27 13:24:05 +01:00
Alan Savage 5782a01b7f Fix bypass_container_update when not detected as available
isAnyUpdateAvailable is not necessarily synced with the PullImage
logic from DockerActionManager. This ensures no images are pulled
regardless of detection.

There's also a minor code improvement to avoid unnecessary interpolation.

Signed-off-by: Alan Savage <3028205+asavageiv@users.noreply.github.com>
2026-03-20 15:42:54 +01:00
Simon L. 0cb0d86471 Merge pull request #7705 from nextcloud/enh/noid/show-stop-and-starting-state
DockerController: refactor `StartBackupContainerBackup` to show the stopping and starting state
2026-03-16 18:03:25 +01:00
Simon L. dfe7eb7ec1 Merge pull request #7721 from nextcloud/enh/7664/backup-restore
DockerController: refactor `StartBackupContainerRestore` to show the stopping and starting state
2026-03-12 18:35:47 +01:00
Simon L. 2016789bea Merge pull request #7741 from nextcloud/hide-from-list
Give all containers a display_name, hide from list by dedicated attribute
2026-03-12 18:31:14 +01:00
Simon L. b0969d9644 Merge pull request #7723 from nextcloud/enh/7664/backup-list
DockerController: refactor `StartBackupContainerList` to show the starting state
2026-03-12 18:24:09 +01:00
Simon L. c4f4ff22c9 Merge pull request #7724 from nextcloud/enh/7664/backup-check-repair
DockerController: refactor `StartBackupContainerCheckRepair` show the starting state
2026-03-12 16:13:36 +01:00
Pablo Zmdl d86eee5847 Give all containers a display_name, hide from list by dedicated attribute
We want a display-name for all containers in the overlay-log, but still want
to exclude some containers from the list on top of the web UI.

Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
2026-03-12 15:44:19 +01:00
Simon L. 49d743c17c DockerController: refactor StartBackupContainerCheckRepair show the starting state
Signed-off-by: Simon L. <szaimen@e.mail.de>
2026-03-09 18:13:21 +01:00
Simon L. c45913a6ff DockerController: refactor StartBackupContainerListto show the starting state
Signed-off-by: Simon L. <szaimen@e.mail.de>
2026-03-09 18:07:46 +01:00
Simon L. 7f394f5297 DockerController: refactor StartBackupContainerTest to show the stopping and starting state
Signed-off-by: Simon L. <szaimen@e.mail.de>
2026-03-09 18:03:05 +01:00
Simon L. e561fad2af DockerController: refactor StartBackupContainerRestore to show the stopping and starting state
Signed-off-by: Simon L. <szaimen@e.mail.de>
2026-03-09 17:55:50 +01:00
Simon L. 6e87758ba9 DockerController: refactor StartBackupContainerBackup to show the stopping and starting state
Signed-off-by: Simon L. <szaimen@e.mail.de>
2026-03-06 10:42:08 +01:00
Simon L. 4b1c7286bc Merge pull request #7675 from nextcloud/enh/7664/backup-check
DockerController: refactor `StartBackupContainerCheck` to show the starting state
2026-03-06 10:38:39 +01:00
Simon L. b248710803 DockerController: refactor StartBackupContainerCheck to show the starting state
Signed-off-by: Simon L. <szaimen@e.mail.de>
2026-03-06 10:16:50 +01:00
Simon L. 9040ccdab8 DockerController: refactor stopping of containers to show the current process
Signed-off-by: Simon L. <szaimen@e.mail.de>
2026-03-06 10:16:08 +01:00
Simon L. 23f5ae2a10 Dockercontroller: refactor streaming responses into dedicated functions and use them in StartWatchtowerContainer method
Signed-off-by: Simon L. <szaimen@e.mail.de>
2026-03-06 10:02:47 +01:00
Simon L. 2fce6352c8 fix starting process not shown if containers are already up-to-date
Signed-off-by: Simon L. <szaimen@e.mail.de>
2026-02-26 11:49:48 +01:00
Pablo Zmdl 680a2fefcb Auto-load only new log data
This is way more complicated that just reloading the log file, but also
way nicer.

Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
2026-02-25 16:45:41 +01:00
Simon L. 92372abfe7 Merge pull request #7458 from nextcloud/enh/6877/show-sub-steps
aio-interface: show sub-steps for starting containers
2026-02-18 13:45:04 +01:00
Pablo Zmdl 56f34703fa Increase cache busters for changed JS and CSS files
Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
2026-02-17 16:35:01 +01:00
Pablo Zmdl bf2d9ff394 Load container status into iframe as streamed response
Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
2026-02-17 16:35:01 +01:00
Simon L. 9652e39be2 aio-interface: offer checkbox to install the new hub release
Signed-off-by: Simon L. <szaimen@e.mail.de>
2026-02-13 09:33:03 +01:00
Julius Knorr 3f4eecaa96 feat: Add office switcher with feature comparison (#7421)
Signed-off-by: Julius Knorr <jus@bitgrid.net>
Signed-off-by: Simon L. <szaimen@e.mail.de>
Signed-off-by: Andrew Backhouse <andrew.backhouse@nextcloud.com>
Co-authored-by: Simon L. <szaimen@e.mail.de>
Co-authored-by: Andrew Backhouse <andrew.backhouse@nextcloud.com>
2026-01-28 09:53:53 +01:00
Simon L. 74138dd838 Merge pull request #7436 from nextcloud/enh/noid/move-version
move version to a dedicated file
2026-01-22 12:10:27 +01:00
Simon L. 52f8c97d45 Merge pull request #7406 from nextcloud/ench/noid/parm
refactor: change private properties to public in Container class
2026-01-22 12:10:15 +01:00
Simon L. 59ad7dc98b move version to a dedicated file
Signed-off-by: Simon L. <szaimen@e.mail.de>
2026-01-16 15:12:44 +01:00
Simon L. 9e362e1dc9 increase to 12.5.0
Signed-off-by: Simon L. <szaimen@e.mail.de>
2026-01-15 13:48:06 +01:00