daenamnu/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/all-in-one.git synced 2026-05-21 10:50:10 +00:00
Code Issues Packages Projects Releases Wiki Activity
8,083 Commits 83 Branches 270 Tags
546474346f86de80d70683552f54bc4d0b01de80
Commit Graph

1778 Commits

Author SHA1 Message Date
copilot-swe-agent[bot]
546474346f some general fixes to the code base 
- Fix return vs continue in CreateVolumes: using return caused all
  subsequent volumes to be skipped when nextcloud_aio_nextcloud_datadir
  or nextcloud_aio_backupdir appeared in the volume list

- Fix GetLogs parsing loop: the while loop checked $line before
  reassigning it so the false sentinel from strtok was always processed,
  appending a spurious extra empty line to the output

- Fix getRegisteredSecret unsafe array access: accessing
  $this->secrets[$secretId] without isset() can trigger an undefined
  array key warning; use isset() instead

- Remove redundant startTransaction() call in setDomain(): the method
  called startTransaction() twice without an intervening commitTransaction(),
  making the second call a no-op that was misleading

Agent-Logs-Url: https://github.com/nextcloud/all-in-one/sessions/19424687-dda1-4510-8f70-068c8d3efd41
Co-Authored-By: szaimen <42591237+szaimen@users.noreply.github.com>
Signed-off-by: Simon L. <szaimen@e.mail.de>
 2026-04-23 10:50:59 +02:00
Simon L.
8de44cf6aa aio-interface: preserve old PHPSESSID session during cookie migration to survive 502s on mastercontainer update (#7971) 2026-04-21 17:55:54 +02:00
Copilot
953a5fdf1e Configurationmanager.php: atomic write for configuration.json to prevent truncation on low disk (#7888) 
* fix: use atomic temp-file write to prevent configuration.json truncation

Agent-Logs-Url: https://github.com/nextcloud/all-in-one/sessions/ea144d2f-2533-4001-8d10-d17168bb8bec

Co-authored-by: szaimen <42591237+szaimen@users.noreply.github.com>

* fix: improve error messages with specific file paths for config write failures

Agent-Logs-Url: https://github.com/nextcloud/all-in-one/sessions/ea144d2f-2533-4001-8d10-d17168bb8bec

Co-authored-by: szaimen <42591237+szaimen@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Pablo Zmdl <57864086+pabzm@users.noreply.github.com>
Signed-off-by: Simon L. <szaimen@e.mail.de>

---------

Signed-off-by: Simon L. <szaimen@e.mail.de>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: szaimen <42591237+szaimen@users.noreply.github.com>
Co-authored-by: Simon L. <szaimen@e.mail.de>
Co-authored-by: Pablo Zmdl <57864086+pabzm@users.noreply.github.com>
 2026-04-20 18:44:33 +02:00
copilot-swe-agent[bot]
301f42d2a0 aio-interface: preserve old PHPSESSID session during cookie migration to survive 502s on mastercontainer update 
Agent-Logs-Url: https://github.com/nextcloud/all-in-one/sessions/aadfe06c-fde4-4a01-953a-42abd110b416

fix: rename $oldSessionTime to $oldSessionTimestamp for clarity

Agent-Logs-Url: https://github.com/nextcloud/all-in-one/sessions/aadfe06c-fde4-4a01-953a-42abd110b416
Co-Authored-By: szaimen <42591237+szaimen@users.noreply.github.com>
 2026-04-20 17:10:23 +02:00
Simon L.
091fb8e814 aio-interface: cache reads from GetDailyBackupTimeFile based on mtime (#7957) 2026-04-20 14:58:21 +02:00
copilot-swe-agent[bot]
ee4088744c aio-interface: cache reads from GetDailyBackupTimeFile based on mtime 
Agent-Logs-Url: https://github.com/nextcloud/all-in-one/sessions/01d18358-7a1e-4747-85f5-3f002aa59253

aio-interface: cache reads from GetDailyBackupTimeFile based on mtime

Agent-Logs-Url: https://github.com/nextcloud/all-in-one/sessions/4df5e1bd-456d-4005-8432-4e9b537c8e54

fix: set dailyBackupFileMtime default to 0 instead of null

Agent-Logs-Url: https://github.com/nextcloud/all-in-one/sessions/ba492f66-d5f0-450f-b0e1-658806bf070d

fix: restore missing closing brace of deleteDailyBackupTime

Agent-Logs-Url: https://github.com/nextcloud/all-in-one/sessions/6e5fb177-9754-4b64-8e93-b5be989f5162
Co-Authored-By: szaimen <42591237+szaimen@users.noreply.github.com>
 2026-04-20 14:50:46 +02:00
Simon L.
ada407751a PHP dependency updates (#7967) 2026-04-20 14:29:11 +02:00
Simon L.
7e628b1200 perf(nextcloud): tune OPcache, APCu, realpath_cache, output_buffering, and Redis session settings (#7946) 2026-04-20 14:21:36 +02:00
szaimen
8ebd624aa8 php dependency updates 
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
 2026-04-20 12:20:28 +00:00
Simon L.
ff86c6d066 perf(fulltextsearch): improve elasticsearch healthcheck and add performance tuning (#7947) 2026-04-20 14:11:20 +02:00
copilot-swe-agent[bot]
144c91ae02 ContainerDefinitionFetcher: cache the containers.json in apcu 
Agent-Logs-Url: https://github.com/nextcloud/all-in-one/sessions/b8bc4ea2-eee0-4e3f-bd71-d1c5a38c93e9

perf: set apc.shm_size=32M explicitly in mastercontainer Dockerfile

Agent-Logs-Url: https://github.com/nextcloud/all-in-one/sessions/4af50c77-4ac1-4947-9b35-dc66d0d0cc8b

perf: revert all previous changes; cache containers.json in APCu

Agent-Logs-Url: https://github.com/nextcloud/all-in-one/sessions/59281e92-7e5d-40ef-a152-78e0620eb949

perf: address review comments - clarify cache comment, restore readonly constructors

Agent-Logs-Url: https://github.com/nextcloud/all-in-one/sessions/b8bc4ea2-eee0-4e3f-bd71-d1c5a38c93e9
Co-Authored-By: szaimen <42591237+szaimen@users.noreply.github.com>
 2026-04-20 13:59:51 +02:00
Simon L.
2b5998e57d aio-interface: enable PHP OPcache and Twig template cache (#7950) 2026-04-20 13:55:33 +02:00
copilot-swe-agent[bot]
3c17a6af36 aio-interface: enable PHP OPcache and Twig template cache 
Agent-Logs-Url: https://github.com/nextcloud/all-in-one/sessions/2d974f3d-5f37-47e9-aa1f-00a43bcd9838
Signed-off-by: Simon L. <szaimen@e.mail.de>
Co-Authored-By: szaimen <42591237+szaimen@users.noreply.github.com>
Signed-off-by: Simon L. <szaimen@e.mail.de>
 2026-04-20 13:47:59 +02:00
Simon L.
ccda322888 aio-interface: combine all disable-*.js files into a single disable-containers.js (#7958) 2026-04-20 13:24:50 +02:00
Simon L.
c428bc3b71 aio-interface: preserve login session across container restarts after cookie name change (#7964) 2026-04-20 13:23:38 +02:00
copilot-swe-agent[bot]
479f68d69e aio-interface: combine all disable-*.js files into disable-containers.js 
Agent-Logs-Url: https://github.com/nextcloud/all-in-one/sessions/a5859e89-d042-4dd5-82e9-9ceed4e22c70
Co-Authored-By: szaimen <42591237+szaimen@users.noreply.github.com>
Signed-off-by: Simon L. <szaimen@e.mail.de>
 2026-04-20 13:15:46 +02:00
Simon L.
e1ae6444e5 increase version of click-handlers 
Signed-off-by: Simon L. <szaimen@e.mail.de>
 2026-04-20 13:08:47 +02:00
copilot-swe-agent[bot]
e378f7faca aio-interface: preserve login session across container restarts after cookie name change 
The session cookie was recently renamed from `PHPSESSID` to
   `__Host-Http-PHPSESSID` (commit 3871179a). When watchtower updates the
   mastercontainer, the browser still holds the old `PHPSESSID` cookie, but the
   new code only looks for `__Host-Http-PHPSESSID`. The old cookie is ignored, a
   fresh unauthenticated session is created, and the user is logged out.

   Fix: before starting the new session in index.php, check if the old `PHPSESSID`
   cookie exists and carries an authenticated session. If it does, destroy the old
   session and mark the new one as authenticated via `SetAuthState(true)`.

Agent-Logs-Url: https://github.com/nextcloud/all-in-one/sessions/cba0ea31-e257-4ec1-82ae-dd66f0f34d98

---

refactor: address review comments - use constant for session key and activity interval

Agent-Logs-Url: https://github.com/nextcloud/all-in-one/sessions/cba0ea31-e257-4ec1-82ae-dd66f0f34d98
Co-Authored-By: szaimen <42591237+szaimen@users.noreply.github.com>
 2026-04-20 13:05:41 +02:00
copilot-swe-agent[bot]
4679c6c38d fix: correct variable shadowing in show-password event handler 
Agent-Logs-Url: https://github.com/nextcloud/all-in-one/sessions/1927b3c2-7484-4876-b037-79d94f2ecb6a

Co-authored-by: szaimen <42591237+szaimen@users.noreply.github.com>
 2026-04-20 10:09:04 +00:00
Simon L.
91e9e58c39 jellyfin: allow Jellyfin to resolve lldap hostname while running in host network mode (#7941) 2026-04-20 11:42:19 +02:00
copilot-swe-agent[bot]
d0b0bde4c8 jellyfin: allow Jellyfin to resolve lldap hostname while running in host network mode 
Agent-Logs-Url: https://github.com/nextcloud/all-in-one/sessions/3bd90eb7-e6f2-4647-9e78-4f9349300a29

fix: use gethostbyname for lldap IP and fix community-container depends_on skip logic

Agent-Logs-Url: https://github.com/nextcloud/all-in-one/sessions/67d6ed5f-8bdc-4b9b-a33c-9ff73305c799

fix: ensure lldap starts before jellyfin via depends_on

Agent-Logs-Url: https://github.com/nextcloud/all-in-one/sessions/448ec7d3-f71e-4499-a4a4-67314434a77c

Update ContainerDefinitionFetcher.php

Signed-off-by: Simon L. <szaimen@e.mail.de>

fix: protect standard container dependencies from being skipped for community containers

Agent-Logs-Url: https://github.com/nextcloud/all-in-one/sessions/cdd6a51b-75a3-4f43-9d00-85b1df2f880f
Co-Authored-By: szaimen <42591237+szaimen@users.noreply.github.com>
 2026-04-20 11:22:24 +02:00
copilot-swe-agent[bot]
310429c5fd fix: add shm_size=128M to nextcloud container to match apc.shm_size 
Agent-Logs-Url: https://github.com/nextcloud/all-in-one/sessions/0b44e4a1-dccc-4541-b4cb-07fceaa046ca

Co-authored-by: szaimen <42591237+szaimen@users.noreply.github.com>
 2026-04-19 22:03:09 +00:00
Simon L.
d2ecff2e06 aio-interface: offer system prune button (#7677) 2026-04-18 12:08:01 +02:00
copilot-swe-agent[bot]
b5dad7927a perf(fulltextsearch): improve elasticsearch healthcheck and add performance tuning settings 
- Replace TCP-only nc healthcheck with HTTP cluster health API check via curl,
  so the container is only marked healthy when ES is actually ready (not just
  when the TCP port is open during startup)
- Add indices.fielddata.cache.size=20% to cap field-data cache and prevent
  unbounded heap growth / OOM kills on large datasets
- Add indices.memory.index_buffer_size=20% to improve bulk indexing throughput
  by buffering more data in memory before flushing to disk
- Add thread_pool.write.queue_size=1000 to avoid rejected indexing requests
  when Nextcloud's background jobs submit many files simultaneously

Changes applied to: Containers/fulltextsearch/healthcheck.sh,
php/containers.json, manual-install/latest.yml

Agent-Logs-Url: https://github.com/nextcloud/all-in-one/sessions/a036678d-a9f5-4db3-8cc6-3e3d52f4e97f

Co-authored-by: szaimen <42591237+szaimen@users.noreply.github.com>
 2026-04-17 15:35:13 +00:00
copilot-swe-agent[bot]
8dea787518 Add shm_size and tmpfs to collabora container for performance improvement 
Agent-Logs-Url: https://github.com/nextcloud/all-in-one/sessions/352eb94e-be98-422a-96d9-39da7e4443cd

Co-authored-by: szaimen <42591237+szaimen@users.noreply.github.com>
 2026-04-17 15:04:58 +00:00
Simon L.
f25f588295 aio-interface: offer system prune button 
Signed-off-by: Simon L. <szaimen@e.mail.de>
Co-Authored-By: szaimen <42591237+szaimen@users.noreply.github.com>
Co-Authored-By: Pablo Zmdl <57864086+pabzm@users.noreply.github.com>
Signed-off-by: Simon L. <szaimen@e.mail.de>
 2026-04-17 14:33:53 +02:00
Simon L.
558b53b2de Merge pull request #7928 from nextcloud/copilot/add-hardware-transcoding-talk-recording 
talk-recording: allow to enable hardware transcoding for the container
 2026-04-17 14:08:59 +02:00
copilot-swe-agent[bot]
1da363ea8c feat: add hardware transcoding support to talk-recording container 
Agent-Logs-Url: https://github.com/nextcloud/all-in-one/sessions/eaea217b-2995-4e47-a4ec-f7be19f98a18

Auto-detect /dev/dri in start.sh and export NEXTCLOUD_ENABLE_DRI_DEVICE automatically

Agent-Logs-Url: https://github.com/nextcloud/all-in-one/sessions/751d0b0c-e529-4ea6-a316-5a53169a9ab6

fix: address code review feedback (nvidia check, file_exists, group_add comment)

Agent-Logs-Url: https://github.com/nextcloud/all-in-one/sessions/eaea217b-2995-4e47-a4ec-f7be19f98a18

Use --device=/dev/dri instead of -v bind-mount in docs and compose

Agent-Logs-Url: https://github.com/nextcloud/all-in-one/sessions/4fa5e70a-b786-445e-946f-a0610751d855
Co-Authored-By: szaimen <42591237+szaimen@users.noreply.github.com>
 2026-04-17 13:49:00 +02:00
Zoey
12e129f1f6 aio-interface: improve headers (#7690) 
Signed-off-by: Zoey <zoey@z0ey.de>
Signed-off-by: Simon L. <szaimen@e.mail.de>
Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
Co-authored-by: Simon L. <szaimen@e.mail.de>
Co-authored-by: Pablo Zmdl <pablo@nextcloud.com>
 2026-04-16 17:20:50 +02:00
szaimen
e8dd1733d7 php dependency updates 
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
 2026-04-16 12:18:59 +00:00
Zoey
3871179a57 aio-interface: set cookie prefix to __Host-Http- (#7912) 
Signed-off-by: Zoey <zoey@z0ey.de>
Signed-off-by: Simon L. <szaimen@e.mail.de>
Co-authored-by: Simon L. <szaimen@e.mail.de>
 2026-04-16 11:12:34 +02:00
szaimen
3678e073a1 php dependency updates 
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
 2026-04-15 12:17:03 +00:00
Simon L.
1f3a2fd537 increase to 13.0.0 
Signed-off-by: Simon L. <szaimen@e.mail.de>
 2026-04-14 15:58:45 +02:00
Simon L.
fcddabbd8e Merge pull request #7880 from nextcloud/enh/7622/hide-update-notice 
aio-interface: hide Hub 26 Winter update notice
 2026-04-14 15:32:45 +02:00
szaimen
e1439a37ac php dependency updates 
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
 2026-04-14 12:17:20 +00:00
Zoey
c104b179b7 aio-interface: improve session config and cookie store (#7689) 
Signed-off-by: Zoey <zoey@z0ey.de>
Co-authored-by: Pablo Zmdl <57864086+pabzm@users.noreply.github.com>
Co-authored-by: Simon L. <szaimen@e.mail.de>
 2026-04-13 11:46:35 +02:00
szaimen
a28e96076c php dependency updates 
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
 2026-04-11 12:06:52 +00:00
szaimen
13c194716d php dependency updates 
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
 2026-04-10 12:13:21 +00:00
Simon L.
d67a6da456 Merge pull request #7856 from nextcloud/aio-dependency-update 
PHP dependency updates
 2026-04-09 14:51:28 +02:00
Simon L.
99c862c2c1 aio-interface: hide Hub 26 Winter update notice 
Signed-off-by: Simon L. <szaimen@e.mail.de>
 2026-04-09 14:30:59 +02:00
szaimen
e9e22cd3c5 php dependency updates 
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
 2026-04-09 12:16:06 +00:00
Pablo Zmdl
b67b3bbe15 Also punish failed logins via GET and URL-token 
Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
 2026-04-07 15:08:01 +02:00
Pablo Zmdl
bc968d18e6 Punish failed login attempts with a delay 
This is a very simple means against bots, until we find the time to discuss
and implement something better.

Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
 2026-04-07 14:52:55 +02:00
Simon L.
b9b622755b increase to 12.9.2 
Signed-off-by: Simon L. <szaimen@e.mail.de>
 2026-04-07 11:37:52 +02:00
Alan Savage
0bad0849c1 Avoid Resend popups on Firefox on start/stop containers 
Use `location.reload(true)` instead of `reload` or `reload(1)`
to ensure we use a GET request.

See also:
https://stackoverflow.com/a/41122753
https://developer.mozilla.org/en-US/docs/Web/API/Location/reload#forceget

Fixes #7850

Signed-off-by: Alan Savage <3028205+asavageiv@users.noreply.github.com>
 2026-04-02 10:55:25 -07:00
Simon L.
7a9bab5776 aio-interface: fix page not automatic reloading after container starting progress spinner 
Signed-off-by: Simon L. <szaimen@e.mail.de>
 2026-04-02 14:06:39 +02:00
Simon L.
c7f0aa8a19 Merge pull request #7840 from nextcloud/hash-equal 
aio-interface: Use timeing-safe password comparison
 2026-04-02 10:26:00 +02:00
Simon L.
2eeada43b5 Merge pull request #7839 from nextcloud/regenerate-session-id 
aio-interface: regenerate session id on login to avoid session fixation attacks
 2026-04-02 10:24:40 +02:00
szaimen
3586dbedb0 php dependency updates 
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
 2026-04-01 12:14:25 +00:00
Pablo Zmdl
2a7c686247 Use timeing-safe password comparison 
AI-assistant: Copilot v1.0.7 (Claude Opus 4.6)

Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
 2026-03-31 23:56:03 +02:00