daenamnu/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/all-in-one.git synced 2026-05-28 06:20:14 +00:00
Code Issues Packages Projects Releases Wiki Activity
8,108 Commits 90 Branches 272 Tags
copilot/create-aio-documentation
Commit Graph

589 Commits

Author SHA1 Message Date
copilot-swe-agent[bot]
546474346f some general fixes to the code base 
- Fix return vs continue in CreateVolumes: using return caused all
  subsequent volumes to be skipped when nextcloud_aio_nextcloud_datadir
  or nextcloud_aio_backupdir appeared in the volume list

- Fix GetLogs parsing loop: the while loop checked $line before
  reassigning it so the false sentinel from strtok was always processed,
  appending a spurious extra empty line to the output

- Fix getRegisteredSecret unsafe array access: accessing
  $this->secrets[$secretId] without isset() can trigger an undefined
  array key warning; use isset() instead

- Remove redundant startTransaction() call in setDomain(): the method
  called startTransaction() twice without an intervening commitTransaction(),
  making the second call a no-op that was misleading

Agent-Logs-Url: https://github.com/nextcloud/all-in-one/sessions/19424687-dda1-4510-8f70-068c8d3efd41
Co-Authored-By: szaimen <42591237+szaimen@users.noreply.github.com>
Signed-off-by: Simon L. <szaimen@e.mail.de>
 2026-04-23 10:50:59 +02:00
Simon L.
8de44cf6aa aio-interface: preserve old PHPSESSID session during cookie migration to survive 502s on mastercontainer update (#7971) 2026-04-21 17:55:54 +02:00
Copilot
953a5fdf1e Configurationmanager.php: atomic write for configuration.json to prevent truncation on low disk (#7888) 
* fix: use atomic temp-file write to prevent configuration.json truncation

Agent-Logs-Url: https://github.com/nextcloud/all-in-one/sessions/ea144d2f-2533-4001-8d10-d17168bb8bec

Co-authored-by: szaimen <42591237+szaimen@users.noreply.github.com>

* fix: improve error messages with specific file paths for config write failures

Agent-Logs-Url: https://github.com/nextcloud/all-in-one/sessions/ea144d2f-2533-4001-8d10-d17168bb8bec

Co-authored-by: szaimen <42591237+szaimen@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Pablo Zmdl <57864086+pabzm@users.noreply.github.com>
Signed-off-by: Simon L. <szaimen@e.mail.de>

---------

Signed-off-by: Simon L. <szaimen@e.mail.de>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: szaimen <42591237+szaimen@users.noreply.github.com>
Co-authored-by: Simon L. <szaimen@e.mail.de>
Co-authored-by: Pablo Zmdl <57864086+pabzm@users.noreply.github.com>
 2026-04-20 18:44:33 +02:00
copilot-swe-agent[bot]
301f42d2a0 aio-interface: preserve old PHPSESSID session during cookie migration to survive 502s on mastercontainer update 
Agent-Logs-Url: https://github.com/nextcloud/all-in-one/sessions/aadfe06c-fde4-4a01-953a-42abd110b416

fix: rename $oldSessionTime to $oldSessionTimestamp for clarity

Agent-Logs-Url: https://github.com/nextcloud/all-in-one/sessions/aadfe06c-fde4-4a01-953a-42abd110b416
Co-Authored-By: szaimen <42591237+szaimen@users.noreply.github.com>
 2026-04-20 17:10:23 +02:00
Simon L.
091fb8e814 aio-interface: cache reads from GetDailyBackupTimeFile based on mtime (#7957) 2026-04-20 14:58:21 +02:00
copilot-swe-agent[bot]
ee4088744c aio-interface: cache reads from GetDailyBackupTimeFile based on mtime 
Agent-Logs-Url: https://github.com/nextcloud/all-in-one/sessions/01d18358-7a1e-4747-85f5-3f002aa59253

aio-interface: cache reads from GetDailyBackupTimeFile based on mtime

Agent-Logs-Url: https://github.com/nextcloud/all-in-one/sessions/4df5e1bd-456d-4005-8432-4e9b537c8e54

fix: set dailyBackupFileMtime default to 0 instead of null

Agent-Logs-Url: https://github.com/nextcloud/all-in-one/sessions/ba492f66-d5f0-450f-b0e1-658806bf070d

fix: restore missing closing brace of deleteDailyBackupTime

Agent-Logs-Url: https://github.com/nextcloud/all-in-one/sessions/6e5fb177-9754-4b64-8e93-b5be989f5162
Co-Authored-By: szaimen <42591237+szaimen@users.noreply.github.com>
 2026-04-20 14:50:46 +02:00
copilot-swe-agent[bot]
144c91ae02 ContainerDefinitionFetcher: cache the containers.json in apcu 
Agent-Logs-Url: https://github.com/nextcloud/all-in-one/sessions/b8bc4ea2-eee0-4e3f-bd71-d1c5a38c93e9

perf: set apc.shm_size=32M explicitly in mastercontainer Dockerfile

Agent-Logs-Url: https://github.com/nextcloud/all-in-one/sessions/4af50c77-4ac1-4947-9b35-dc66d0d0cc8b

perf: revert all previous changes; cache containers.json in APCu

Agent-Logs-Url: https://github.com/nextcloud/all-in-one/sessions/59281e92-7e5d-40ef-a152-78e0620eb949

perf: address review comments - clarify cache comment, restore readonly constructors

Agent-Logs-Url: https://github.com/nextcloud/all-in-one/sessions/b8bc4ea2-eee0-4e3f-bd71-d1c5a38c93e9
Co-Authored-By: szaimen <42591237+szaimen@users.noreply.github.com>
 2026-04-20 13:59:51 +02:00
copilot-swe-agent[bot]
e378f7faca aio-interface: preserve login session across container restarts after cookie name change 
The session cookie was recently renamed from `PHPSESSID` to
   `__Host-Http-PHPSESSID` (commit 3871179a). When watchtower updates the
   mastercontainer, the browser still holds the old `PHPSESSID` cookie, but the
   new code only looks for `__Host-Http-PHPSESSID`. The old cookie is ignored, a
   fresh unauthenticated session is created, and the user is logged out.

   Fix: before starting the new session in index.php, check if the old `PHPSESSID`
   cookie exists and carries an authenticated session. If it does, destroy the old
   session and mark the new one as authenticated via `SetAuthState(true)`.

Agent-Logs-Url: https://github.com/nextcloud/all-in-one/sessions/cba0ea31-e257-4ec1-82ae-dd66f0f34d98

---

refactor: address review comments - use constant for session key and activity interval

Agent-Logs-Url: https://github.com/nextcloud/all-in-one/sessions/cba0ea31-e257-4ec1-82ae-dd66f0f34d98
Co-Authored-By: szaimen <42591237+szaimen@users.noreply.github.com>
 2026-04-20 13:05:41 +02:00
Simon L.
91e9e58c39 jellyfin: allow Jellyfin to resolve lldap hostname while running in host network mode (#7941) 2026-04-20 11:42:19 +02:00
copilot-swe-agent[bot]
d0b0bde4c8 jellyfin: allow Jellyfin to resolve lldap hostname while running in host network mode 
Agent-Logs-Url: https://github.com/nextcloud/all-in-one/sessions/3bd90eb7-e6f2-4647-9e78-4f9349300a29

fix: use gethostbyname for lldap IP and fix community-container depends_on skip logic

Agent-Logs-Url: https://github.com/nextcloud/all-in-one/sessions/67d6ed5f-8bdc-4b9b-a33c-9ff73305c799

fix: ensure lldap starts before jellyfin via depends_on

Agent-Logs-Url: https://github.com/nextcloud/all-in-one/sessions/448ec7d3-f71e-4499-a4a4-67314434a77c

Update ContainerDefinitionFetcher.php

Signed-off-by: Simon L. <szaimen@e.mail.de>

fix: protect standard container dependencies from being skipped for community containers

Agent-Logs-Url: https://github.com/nextcloud/all-in-one/sessions/cdd6a51b-75a3-4f43-9d00-85b1df2f880f
Co-Authored-By: szaimen <42591237+szaimen@users.noreply.github.com>
 2026-04-20 11:22:24 +02:00
Simon L.
f25f588295 aio-interface: offer system prune button 
Signed-off-by: Simon L. <szaimen@e.mail.de>
Co-Authored-By: szaimen <42591237+szaimen@users.noreply.github.com>
Co-Authored-By: Pablo Zmdl <57864086+pabzm@users.noreply.github.com>
Signed-off-by: Simon L. <szaimen@e.mail.de>
 2026-04-17 14:33:53 +02:00
Simon L.
558b53b2de Merge pull request #7928 from nextcloud/copilot/add-hardware-transcoding-talk-recording 
talk-recording: allow to enable hardware transcoding for the container
 2026-04-17 14:08:59 +02:00
copilot-swe-agent[bot]
1da363ea8c feat: add hardware transcoding support to talk-recording container 
Agent-Logs-Url: https://github.com/nextcloud/all-in-one/sessions/eaea217b-2995-4e47-a4ec-f7be19f98a18

Auto-detect /dev/dri in start.sh and export NEXTCLOUD_ENABLE_DRI_DEVICE automatically

Agent-Logs-Url: https://github.com/nextcloud/all-in-one/sessions/751d0b0c-e529-4ea6-a316-5a53169a9ab6

fix: address code review feedback (nvidia check, file_exists, group_add comment)

Agent-Logs-Url: https://github.com/nextcloud/all-in-one/sessions/eaea217b-2995-4e47-a4ec-f7be19f98a18

Use --device=/dev/dri instead of -v bind-mount in docs and compose

Agent-Logs-Url: https://github.com/nextcloud/all-in-one/sessions/4fa5e70a-b786-445e-946f-a0610751d855
Co-Authored-By: szaimen <42591237+szaimen@users.noreply.github.com>
 2026-04-17 13:49:00 +02:00
Zoey
12e129f1f6 aio-interface: improve headers (#7690) 
Signed-off-by: Zoey <zoey@z0ey.de>
Signed-off-by: Simon L. <szaimen@e.mail.de>
Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
Co-authored-by: Simon L. <szaimen@e.mail.de>
Co-authored-by: Pablo Zmdl <pablo@nextcloud.com>
 2026-04-16 17:20:50 +02:00
Pablo Zmdl
b67b3bbe15 Also punish failed logins via GET and URL-token 
Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
 2026-04-07 15:08:01 +02:00
Pablo Zmdl
bc968d18e6 Punish failed login attempts with a delay 
This is a very simple means against bots, until we find the time to discuss
and implement something better.

Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
 2026-04-07 14:52:55 +02:00
Simon L.
c7f0aa8a19 Merge pull request #7840 from nextcloud/hash-equal 
aio-interface: Use timeing-safe password comparison
 2026-04-02 10:26:00 +02:00
Pablo Zmdl
2a7c686247 Use timeing-safe password comparison 
AI-assistant: Copilot v1.0.7 (Claude Opus 4.6)

Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
 2026-03-31 23:56:03 +02:00
Pablo Zmdl
f9e6339044 Regenerate session id on login to avoid session fixation attacks 
AI-assistant: Copilot v1.0.7 (Claude Opus 4.6)

Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
 2026-03-31 23:54:56 +02:00
Simon L.
7dc489168a psalm: revert changes 
Signed-off-by: Simon L. <szaimen@e.mail.de>
 2026-03-19 13:51:12 +01:00
Simon L.
f1eeea9337 ignore psalm error 
Signed-off-by: Simon L. <szaimen@e.mail.de>
 2026-03-18 19:58:53 +01:00
Pablo Zmdl
b169790488 Fix streaming responses in Caddy 
Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
 2026-03-18 17:53:54 +01:00
Simon L.
0cb0d86471 Merge pull request #7705 from nextcloud/enh/noid/show-stop-and-starting-state 
DockerController: refactor `StartBackupContainerBackup` to show the stopping and starting state
 2026-03-16 18:03:25 +01:00
Simon L.
dfe7eb7ec1 Merge pull request #7721 from nextcloud/enh/7664/backup-restore 
DockerController: refactor `StartBackupContainerRestore` to show the stopping and starting state
 2026-03-12 18:35:47 +01:00
Simon L.
2016789bea Merge pull request #7741 from nextcloud/hide-from-list 
Give all containers a display_name, hide from list by dedicated attribute
 2026-03-12 18:31:14 +01:00
Simon L.
b0969d9644 Merge pull request #7723 from nextcloud/enh/7664/backup-list 
DockerController: refactor `StartBackupContainerList` to show the starting state
 2026-03-12 18:24:09 +01:00
Pablo Zmdl
6e8c8dab19 Reorder arguments 
Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
 2026-03-12 17:34:51 +01:00
Simon L.
1e23c1a6dd apply suggestions by @pabzm 
Co-authored-by: Pablo Zmdl <57864086+pabzm@users.noreply.github.com>
Signed-off-by: Simon L. <szaimen@e.mail.de>
 2026-03-12 16:20:17 +01:00
Simon L.
c4f4ff22c9 Merge pull request #7724 from nextcloud/enh/7664/backup-check-repair 
DockerController: refactor `StartBackupContainerCheckRepair` show the starting state
 2026-03-12 16:13:36 +01:00
Pablo Zmdl
d86eee5847 Give all containers a display_name, hide from list by dedicated attribute 
We want a display-name for all containers in the overlay-log, but still want
to exclude some containers from the list on top of the web UI.

Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
 2026-03-12 15:44:19 +01:00
Simon L.
49d743c17c DockerController: refactor StartBackupContainerCheckRepair show the starting state 
Signed-off-by: Simon L. <szaimen@e.mail.de>
 2026-03-09 18:13:21 +01:00
Simon L.
c45913a6ff DockerController: refactor StartBackupContainerListto show the starting state 
Signed-off-by: Simon L. <szaimen@e.mail.de>
 2026-03-09 18:07:46 +01:00
Simon L.
7f394f5297 DockerController: refactor StartBackupContainerTest to show the stopping and starting state 
Signed-off-by: Simon L. <szaimen@e.mail.de>
 2026-03-09 18:03:05 +01:00
Simon L.
e561fad2af DockerController: refactor StartBackupContainerRestore to show the stopping and starting state 
Signed-off-by: Simon L. <szaimen@e.mail.de>
 2026-03-09 17:55:50 +01:00
Simon L.
6e87758ba9 DockerController: refactor StartBackupContainerBackup to show the stopping and starting state 
Signed-off-by: Simon L. <szaimen@e.mail.de>
 2026-03-06 10:42:08 +01:00
Simon L.
4b1c7286bc Merge pull request #7675 from nextcloud/enh/7664/backup-check 
DockerController: refactor `StartBackupContainerCheck` to show the starting state
 2026-03-06 10:38:39 +01:00
Simon L.
b248710803 DockerController: refactor StartBackupContainerCheck to show the starting state 
Signed-off-by: Simon L. <szaimen@e.mail.de>
 2026-03-06 10:16:50 +01:00
Simon L.
9040ccdab8 DockerController: refactor stopping of containers to show the current process 
Signed-off-by: Simon L. <szaimen@e.mail.de>
 2026-03-06 10:16:08 +01:00
Simon L.
23f5ae2a10 Dockercontroller: refactor streaming responses into dedicated functions and use them in StartWatchtowerContainer method 
Signed-off-by: Simon L. <szaimen@e.mail.de>
 2026-03-06 10:02:47 +01:00
Pablo Zmdl
680a2fefcb Auto-load only new log data 
This is way more complicated that just reloading the log file, but also
way nicer.

Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
 2026-02-25 16:45:41 +01:00
Pablo Zmdl
862a17ab4e Auto-reload the log view, and scroll to bottom. 
Includes a button to disable the automatic reloading (useful when inspecting some lines in the middle).

Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
 2026-02-20 14:22:57 +01:00
Simon L.
91b8593a6c Merge pull request #7619 from nextcloud/enh/7612/prevent-image-hash 
fix getting name of mastercontainer if a hash was found
 2026-02-18 13:53:46 +01:00
Oleksandr Piskun
987191ac14 feat(app-api): add HaRP container (#7493) 
Signed-off-by: Oleksander Piskun <oleksandr2088@icloud.com>
Signed-off-by: bigcat88 <bigcat88@icloud.com>
Signed-off-by: Oleksandr Piskun <oleksandr2088@icloud.com>
Signed-off-by: Simon L. <szaimen@e.mail.de>
Co-authored-by: Simon L. <szaimen@e.mail.de>
 2026-02-18 13:45:44 +01:00
Simon L.
92372abfe7 Merge pull request #7458 from nextcloud/enh/6877/show-sub-steps 
aio-interface: show sub-steps for starting containers
 2026-02-18 13:45:04 +01:00
Pablo Zmdl
56f34703fa Increase cache busters for changed JS and CSS files 
Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
 2026-02-17 16:35:01 +01:00
Pablo Zmdl
bf2d9ff394 Load container status into iframe as streamed response 
Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
 2026-02-17 16:35:01 +01:00
Simon L.
1d85bfe302 fix getting name of mastercontainer if a hash was found 
Signed-off-by: Simon L. <szaimen@e.mail.de>
 2026-02-17 14:49:55 +01:00
Simon L.
bdda7c2178 Merge pull request #7541 from nextcloud/enh/noid/use-strict-types-in-php 
add `declare(strict_types=1);` to all php files
 2026-02-13 10:54:23 +01:00
Simon L.
fe4f568d02 Merge pull request #7578 from nextcloud/enh/noid/fix-bug-with-fts 
fix bug with FTS not being able to enable it anymore
 2026-02-13 10:53:34 +01:00
Simon L.
9652e39be2 aio-interface: offer checkbox to install the new hub release 
Signed-off-by: Simon L. <szaimen@e.mail.de>
 2026-02-13 09:33:03 +01:00