daenamnu/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/all-in-one.git synced 2026-05-28 22:40:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

extract DEDYN_SUFFIX to ConfigurationManager constant; improve password comment

Browse Source 
Agent-Logs-Url: https://github.com/nextcloud/all-in-one/sessions/10d22120-1d15-4613-bcb4-a7ca9f3705ce

Co-authored-by: szaimen <42591237+szaimen@users.noreply.github.com>
This commit is contained in:
copilot-swe-agent[bot]
2026-04-25 12:03:46 +00:00
committed by GitHub
parent e0305457fd
commit 5d85a156b0
2 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
php/src/Controller/DesecController.php
View File

@@ -11,7 +11,6 @@ use Psr\Http\Message\ServerRequestInterface as Request;
readonly class DesecController {
private const string DESEC_API_BASE = 'https://desec.io/api/v1';
private const string DEDYN_SUFFIX = '.dedyn.io';
private const int MAX_SLUG_ATTEMPTS = 5;
private const int SLUG_BYTES = 5; // bin2hex → 10-char slug
private const string SLUG_PATTERN = '/^[a-z0-9]([a-z0-9-]{0,61}[a-z0-9])?$/';
@@ -57,7 +56,8 @@ readonly class DesecController {
try {
if (!$accountAlreadyRegistered) {
// 24 random bytes → 48-char hex password, stored so the user can log in at desec.io.
// 24 random bytes produce a 48-char hex password, satisfying deSEC's minimum
// length requirement and stored so the user can log in at desec.io if needed.
$password = bin2hex(random_bytes(24));
$token = $this->registerDesecAccount($email, $password);
@@ -158,7 +158,7 @@ readonly class DesecController {
$attempts = $random ? self::MAX_SLUG_ATTEMPTS : 1;
for ($i = 0; $i < $attempts; $i++) {
$domain = ($random ? bin2hex(random_bytes(self::SLUG_BYTES)) : $slug) . self::DEDYN_SUFFIX;
$domain = ($random ? bin2hex(random_bytes(self::SLUG_BYTES)) : $slug) . ConfigurationManager::DEDYN_SUFFIX;
try {
$res = $this->guzzleClient->post(self::DESEC_API_BASE . '/domains/', [