Merge pull request #478 from nextcloud/enh/noid/update-handling

improve update handling when changing channels
This commit is contained in:
Simon L
2022-04-13 15:41:06 +02:00
committed by GitHub
2 changed files with 4 additions and 3 deletions

View File

@@ -100,7 +100,7 @@ class DockerActionManager
$runningDigest = $this->GetRepoDigestOfContainer($container->GetIdentifier());
$remoteDigest = $this->dockerHubManager->GetLatestDigestOfTag($container->GetContainerName(), $tag);
if ($runningDigest === $remoteDigest || $remoteDigest === null || $runningDigest === null) {
if ($runningDigest === $remoteDigest || $remoteDigest === null) {
return new VersionEqualState();
} else {
return new VersionDifferentState();
@@ -375,7 +375,6 @@ class DockerActionManager
return null;
} catch (\Exception $e) {
error_log('Could not get digest of container ' . $this->BuildApiUrl($containerName) . ' ' . $e->getMessage());
return null;
}
}
@@ -413,7 +412,7 @@ class DockerActionManager
$runningDigest = $this->GetRepoDigestOfContainer($containerName);
$remoteDigest = $this->dockerHubManager->GetLatestDigestOfTag($imageName, $tag);
if ($remoteDigest === $runningDigest || $remoteDigest === null || $runningDigest === null) {
if ($remoteDigest === $runningDigest || $remoteDigest === null) {
return false;
} else {
return true;

View File

@@ -52,8 +52,10 @@ class DockerHubManager
}
}
error_log('Could not get digest of container ' . $name . ':' . $tag);
return null;
} catch (\Exception $e) {
error_log('Could not get digest of container ' . $name . ':' . $tag . ' ' . $e->getMessage());
return null;
}
}