From 4679c6c38df16269a2b7d3d6ca7f973805af4b68 Mon Sep 17 00:00:00 2001
From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com>
Date: Mon, 20 Apr 2026 10:09:04 +0000
Subject: [PATCH] fix: correct variable shadowing in show-password event
 handler

Agent-Logs-Url: https://github.com/nextcloud/all-in-one/sessions/1927b3c2-7484-4876-b037-79d94f2ecb6a

Co-authored-by: szaimen <42591237+szaimen@users.noreply.github.com>
---
 php/public/click-handlers.js  | 4 ++--
 php/templates/containers.twig | 4 ++--
 php/templates/login.twig      | 2 +-
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/php/public/click-handlers.js b/php/public/click-handlers.js
index 88aa0d4a..3e2f3a75 100644
--- a/php/public/click-handlers.js
+++ b/php/public/click-handlers.js
@@ -9,8 +9,8 @@ document.addEventListener("DOMContentLoaded", () => {
 
 
     document.querySelectorAll('input[data-input-show-password]').forEach((element) => {
-        element.addEventListener('input', (element) => {
-            let passwordField = element
+        element.addEventListener('input', (event) => {
+            let passwordField = event.target;
             if (passwordField.type === "password" && passwordField.value !== "") {
                 passwordField.type = "text";
             } else if (passwordField.type === "text" && passwordField.value === "") {
diff --git a/php/templates/containers.twig b/php/templates/containers.twig
index 207cfceb..adfe3161 100644
--- a/php/templates/containers.twig
+++ b/php/templates/containers.twig
@@ -599,8 +599,8 @@
                                     <summary>Click here to change your AIO passphrase</summary>
                                     <p>You can change your AIO passphrase below:</p>
                                     <form method="POST" action="api/configuration" class="xhr">
-                                        <input type="password" autocomplete="current-password" name="current-master-password" placeholder="Your current AIO passphrase" id="current-master-password" data-input-show-password="showPassword('current-master-password')">
-                                        <input type="password" autocomplete="new-password" name="new-master-password" placeholder="Your new AIO passphrase" id="new-master-password" data-input-show-password="showPassword('new-master-password')">
+                                        <input type="password" autocomplete="current-password" name="current-master-password" placeholder="Your current AIO passphrase" id="current-master-password" data-input-show-password>
+                                        <input type="password" autocomplete="new-password" name="new-master-password" placeholder="Your new AIO passphrase" id="new-master-password" data-input-show-password>
                                         <input type="hidden" name="{{csrf.keys.name}}" value="{{csrf.name}}">
                                         <input type="hidden" name="{{csrf.keys.value}}" value="{{csrf.value}}">
                                         <input type="submit" value="Submit passphrase change" />
diff --git a/php/templates/login.twig b/php/templates/login.twig
index 88432e48..74c29bef 100644
--- a/php/templates/login.twig
+++ b/php/templates/login.twig
@@ -11,7 +11,7 @@
         {% if is_login_allowed == true %}
             <p>Log in using your Nextcloud AIO passphrase:</p>
             <form method="POST" action="api/auth/login" class="xhr">
-                <input type="password" autocomplete="current-password" name="password" placeholder="Password" id="master-password" data-input-show-password="showPassword('master-password')">
+                <input type="password" autocomplete="current-password" name="password" placeholder="Password" id="master-password" data-input-show-password>
                 <input type="hidden" name="{{csrf.keys.name}}" value="{{csrf.name}}">
                 <input type="hidden" name="{{csrf.keys.value}}" value="{{csrf.value}}">
                 <input type="submit" class="button" value="Log in" />