daenamnu/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/all-in-one.git synced 2026-07-21 21:52:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat(desec): run registration flow in a modal iframe

Browse Source 
Move the deSEC "register a free domain" flow out of the inline containers
page form and into a modal backed by a dedicated /desec view loaded in an
iframe. The multi-step register -> verify -> domain process now re-renders
inside the modal, so the user can adjust the details and complete email
verification without reloading the whole page each step. Only once the
domain is fully registered does the view reload the parent containers page.

- add /desec route + desec.twig standalone view
- add desec-modal.js (open/close, backdrop + Escape) and desec-done.js
  (parent reload on completion)
- redirect register POST to the /desec view so steps stay in the modal
- drop the redundant <details> wrapper in desec-register.twig, add heading
- style the modal and let <button class="button"> pick up button styles
- drive the modal iframe in the Playwright specs and update the QA checklist

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Signed-off-by: Simon L. <szaimen@e.mail.de>
This commit is contained in:
Simon L.
2026-06-22 13:22:37 +02:00
parent 164b150817
commit 454905c852
11 changed files with 275 additions and 67 deletions
Download Patch File Download Diff File Expand all files Collapse all files
php/tests/tests/desec-existing.spec.js
+12 -4
View File
@@ -5,6 +5,9 @@ import { DESEC_MOCK_URL, logInToContainersPage } from './desec-helpers.js';
// password logs straight in and registers the domain in one step (no email-verification
// round-trip). See desec-register.spec.js for the full setup notes.
//
// As in the register flow, the form is driven inside the modal iframe (the /desec view);
// on success the iframe reloads the parent containers page.
//
// This flow also ends by registering a domain, so it is run as its own CI step with the
// deSEC state re-seeded beforehand (configuration.json must have no domain set for the
// registration UI to render).
@@ -28,13 +31,18 @@ test('deSEC existing-account login flow', async ({ page: setupPage }) => {
const slug = `aio-existing-${Math.floor(Math.random() * 2147483647)}`;
// Open the deSEC registration entry point and launch the modal.
await containersPage.getByText("Don't have a domain? Get a free one from deSEC").click();
await containersPage.locator('input[name="desec_email"]').fill(email);
await containersPage.locator('input[name="desec_password"]').fill(password);
await containersPage.locator('input[name="desec_slug"]').first().fill(slug);
await containersPage.getByRole('button', { name: 'Register free domain via deSEC' }).click();
// Supplying a valid password logs straight in and registers the domain in one step.
const frame = containersPage.frameLocator('#desec-frame');
await frame.locator('input[name="desec_email"]').fill(email);
await frame.locator('input[name="desec_password"]').fill(password);
await frame.locator('input[name="desec_slug"]').first().fill(slug);
await frame.getByRole('button', { name: 'Register free domain via deSEC' }).click();
// Supplying a valid password logs straight in and registers the domain in one step; the
// modal view then reloads the parent containers page.
await expect(containersPage.getByRole('button', { name: 'Download and start containers' })).toBeVisible({ timeout: 60 * 1000 });
await expect(
containersPage.getByText("Don't have a domain? Get a free one from deSEC"),
php/tests/tests/desec-register.spec.js
+26 -17
View File
@@ -3,11 +3,16 @@ import { DESEC_MOCK_URL, logInToContainersPage } from './desec-helpers.js';
// Drives the real AIO interface through the full deSEC "register a free domain" flow
// against the local mock (php/tests/desec-mock.mjs). The mastercontainer must be started
// with SKIP_DOMAIN_VALIDATION=false (so the deSEC registration form is rendered) and its
// configuration.json must point desec_api_base / desec_update_url at the mock (see the
// with SKIP_DOMAIN_VALIDATION=false (so the deSEC registration entry point is rendered) and
// its configuration.json must point desec_api_base / desec_update_url at the mock (see the
// Playwright CI workflow). The mock's control endpoint is reachable from the test runner
// on the host at DESEC_MOCK_URL (default http://localhost:8090).
//
// The registration runs inside a modal iframe (the /desec view): the multi-step
// register -> verify -> domain flow re-renders inside the iframe so the user can adjust the
// details and complete email verification without reloading the whole containers page. Only
// once the domain is fully registered does the iframe reload the parent page.
//
// This flow ends by registering a domain, which persists in configuration.json. It is
// therefore run as its own CI step; the deSEC state is reset (re-seeded) before the
// separate existing-account flow runs.
@@ -23,33 +28,37 @@ test('deSEC register -> verify -> domain flow', async ({ page: setupPage }) => {
const email = `e2e-${Math.floor(Math.random() * 2147483647)}@example.com`;
const slug = `aio-e2e-${Math.floor(Math.random() * 2147483647)}`;
// Open the deSEC registration section.
// Open the deSEC registration entry point and launch the modal.
await containersPage.getByText("Don't have a domain? Get a free one from deSEC").click();
await containersPage.getByRole('button', { name: 'Register free domain via deSEC' }).click();
// The flow lives inside the modal iframe (the /desec view).
const frame = containersPage.frameLocator('#desec-frame');
// 1) Submit email only -> a new account is "created" (mock 202) and AIO asks the user
// to verify their email. This is a normal (non-error) state transition: the page
// reloads into the awaiting-verification UI, which renders inside <main> and shows
// the dedicated re-submit button.
await containersPage.locator('input[name="desec_email"]').fill(email);
await containersPage.locator('input[name="desec_slug"]').first().fill(slug);
await containersPage.getByRole('button', { name: 'Register free domain via deSEC' }).click();
await expect(containersPage.getByRole('main')).toContainText('check your inbox', { timeout: 30 * 1000 });
// to verify their email. This is a normal (non-error) state transition: the iframe
// reloads into the awaiting-verification step inside the modal.
await frame.locator('input[name="desec_email"]').fill(email);
await frame.locator('input[name="desec_slug"]').first().fill(slug);
await frame.getByRole('button', { name: 'Register free domain via deSEC' }).click();
await expect(frame.getByText('check your inbox')).toBeVisible({ timeout: 30 * 1000 });
await expect(
containersPage.getByRole('button', { name: 'I have verified my email – register domain' }),
frame.getByRole('button', { name: 'I have verified my email – register domain' }),
).toBeVisible();
// 2) Re-submit BEFORE verifying -> login still fails (mock 403) -> friendly hint shown.
await containersPage.getByRole('button', { name: 'I have verified my email – register domain' }).click();
// Same as above: the failure hint is a transient toast, not <main> content.
await expect(containersPage.locator('.toast.error')).toContainText('Could not log in to deSEC', { timeout: 8 * 1000 });
// The error is a transient toast rendered inside the iframe.
await frame.getByRole('button', { name: 'I have verified my email – register domain' }).click();
await expect(frame.locator('.toast.error')).toContainText('Could not log in to deSEC', { timeout: 8 * 1000 });
// 3) Simulate the user clicking the verification link in their email.
const verifyResponse = await fetch(`${DESEC_MOCK_URL}/__control/verify`, { method: 'POST' });
expect(verifyResponse.status).toBe(200);
// 4) Re-submit after verification -> login succeeds, domain is registered, the deSEC
// section disappears and the container-start UI appears.
await containersPage.getByRole('button', { name: 'I have verified my email – register domain' }).click();
// 4) Re-submit after verification -> login succeeds, the domain is registered and the
// modal view reloads the parent page, where the deSEC entry point is gone and the
// container-start UI appears.
await frame.getByRole('button', { name: 'I have verified my email – register domain' }).click();
await expect(containersPage.getByRole('button', { name: 'Download and start containers' })).toBeVisible({ timeout: 60 * 1000 });
await expect(
containersPage.getByText("Don't have a domain? Get a free one from deSEC"),