From 1fdda554210407aa5fe4f6c0ae5ab0f6da17690b Mon Sep 17 00:00:00 2001 From: "Simon L." Date: Tue, 23 Jun 2026 14:52:05 +0200 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Pablo Zmdl <57864086+pabzm@users.noreply.github.com> Signed-off-by: Simon L. --- php/templates/containers.twig | 2 +- php/templates/includes/desec-domain-notice.twig | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/php/templates/containers.twig b/php/templates/containers.twig index 6284ff14..8537ecc3 100644 --- a/php/templates/containers.twig +++ b/php/templates/containers.twig @@ -122,7 +122,7 @@
Don't have a domain? Get a free one from deSEC -

deSEC offers free dynamic DNS subdomains under dedyn.io. AIO can register an account and a subdomain for you automatically. Click the button below to start; the registration runs in a small window so you can adjust the details and complete the email verification without losing this page. Once it's done, this page reloads with your new domain configured.

+

deSEC offers free dynamic DNS subdomains under dedyn.io. AIO can register an account and a subdomain for you automatically. Click the button below to start; the registration runs in a small window so you can adjust the details and complete the email verification without losing this page. Once it's done, this page reloads with your new domain configured. (To make your instance available publicly you additionally would have to make sure that port 443 is open in your server's firewall, and – if applicable – the port is also forwarded by your router to your server. See below for more details on port forwarding.)

{% if desec_awaiting_verification or desec_account_registered %}

⚠️ A deSEC registration for {{ desec_email }} is already in progress but not finished yet. Click the button below to continue it.

diff --git a/php/templates/includes/desec-domain-notice.twig b/php/templates/includes/desec-domain-notice.twig index 67c3e008..4735c0d0 100644 --- a/php/templates/includes/desec-domain-notice.twig +++ b/php/templates/includes/desec-domain-notice.twig @@ -1,3 +1,3 @@

ℹ️ Your Nextcloud domain ({{ domain }}) was registered via deSEC. The caddy community container has been automatically enabled as a reverse proxy and the dnsmasq container has been automatically enabled so that LAN devices can resolve your Nextcloud domain to the server's local IP address. Please read the dnsmasq documentation for the required router change.

-

⚠️ Caution: if this is a publicly reachable instance, you must disable dnsmasq again as dnsmasq must only run on home servers where port 53 is not publicly exposed.

-

⚠️ Note: dnsmasq's automatic local IP address detection only works on a native Linux host. On Docker Desktop (Windows/macOS) it cannot determine the machine's real LAN IP, so local DNS resolution will not work there.

+

ℹ️ Note: dnsmasq's automatic local IP address detection only works on a native Linux host. On Docker Desktop (Windows/macOS) it cannot determine the machine's real LAN IP, so local DNS resolution will not work there. To work around the problem, you can set up a local dns server externally or use the pi-hole community container and point the domain to the local ip-address of the server.

+

⚠️ Caution: Make sure that your server's port 53 is *not* reachable from the internet! E.g. block it in your firewall, or (if you don't need local network access to your instance because it is reachable publicly) disable the container by scrolling to the very bottom of this page and expanding the community containers list and unchecking dnsmasq.