From f70a989a21dc03dfa9d1d6494c9df4f6a7b9e1fc Mon Sep 17 00:00:00 2001
From: ITOH <72305210+itohatweb@users.noreply.github.com>
Date: Sat, 23 Jan 2021 20:15:11 +0100
Subject: [PATCH 1/6] types: better types (#413)

* Update cache.ts

* Update shard_manager.ts
---
 src/util/cache.ts       | 11 ++++++++---
 src/ws/shard_manager.ts |  8 +++++---
 2 files changed, 13 insertions(+), 6 deletions(-)

diff --git a/src/util/cache.ts b/src/util/cache.ts
index c3be7a26c..61fa1a7ba 100644
--- a/src/util/cache.ts
+++ b/src/util/cache.ts
@@ -10,9 +10,14 @@ export interface CacheData {
   members: Collection<string, Member>;
   unavailableGuilds: Collection<string, number>;
   presences: Collection<string, PresenceUpdatePayload>;
-  // TODO: The type Collection's second provided generic [function] should have a definite shape.
-  // deno-lint-ignore ban-types
-  fetchAllMembersProcessingRequests: Collection<string, Function>;
+  fetchAllMembersProcessingRequests: Collection<
+    string,
+    (
+      value:
+        | Collection<string, Member>
+        | PromiseLike<Collection<string, Member>>,
+    ) => void
+  >;
   executedSlashCommands: Collection<string, string>;
 }
 
diff --git a/src/ws/shard_manager.ts b/src/ws/shard_manager.ts
index 4692632f4..4d92625fa 100644
--- a/src/ws/shard_manager.ts
+++ b/src/ws/shard_manager.ts
@@ -1,5 +1,6 @@
 import { controllers } from "../api/controllers/mod.ts";
 import { Guild } from "../api/structures/guild.ts";
+import { Member } from "../api/structures/mod.ts";
 import { eventHandlers, IdentifyPayload } from "../bot.ts";
 import {
   DiscordBotGatewayData,
@@ -8,6 +9,7 @@ import {
   GatewayOpcode,
 } from "../types/mod.ts";
 import { cache } from "../util/cache.ts";
+import { Collection } from "../util/collection.ts";
 import { BotStatusRequest, delay } from "../util/utils.ts";
 import {
   botGatewayStatusRequest,
@@ -90,9 +92,9 @@ export async function handleDiscordPayload(
 
 export function requestAllMembers(
   guild: Guild,
-  // TODO: The parameter "resolve" should have a "stronger" type.
-  // deno-lint-ignore ban-types
-  resolve: Function,
+  resolve: (
+    value: Collection<string, Member> | PromiseLike<Collection<string, Member>>,
+  ) => void,
   options?: FetchMembersOptions,
 ) {
   const nonce = `${guild.id}-${Date.now()}`;

From 26f8321ee9d359eb3328f0e00b7a039b0c69ad5f Mon Sep 17 00:00:00 2001
From: ITOH <72305210+itohatweb@users.noreply.github.com>
Date: Sat, 23 Jan 2021 20:16:04 +0100
Subject: [PATCH 2/6] feat(ws): add additional info to wsError debug event
 (#434)

* feat(ws): better error debug message

* Update src/ws/shard.ts

Co-authored-by: Ayyan <ayyantee@gmail.com>

Co-authored-by: Ayyan <ayyantee@gmail.com>
---
 src/ws/shard.ts | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/src/ws/shard.ts b/src/ws/shard.ts
index 748c4f941..1acd29a3f 100644
--- a/src/ws/shard.ts
+++ b/src/ws/shard.ts
@@ -67,8 +67,11 @@ export function createShard(
     }
   };
 
-  ws.onerror = ({ timeStamp }) => {
-    eventHandlers.debug?.({ type: "wsError", data: { timeStamp } });
+  ws.onerror = (errorEvent) => {
+    eventHandlers.debug?.({
+      type: "wsError",
+      data: { shardID: basicShard.id, ...errorEvent },
+    });
   };
 
   ws.onmessage = ({ data: message }) => {

From f6f435bb1f0ed89640c4f5d105c1d9fc249bb30f Mon Sep 17 00:00:00 2001
From: ITOH <72305210+itohatweb@users.noreply.github.com>
Date: Sat, 23 Jan 2021 20:17:11 +0100
Subject: [PATCH 3/6] feat(handlers): add getAvailableVoiceRegions() (#425)

* add voice endpoint

* feat(handlers): add getVoiceRegions

* Update mod.ts

* remove breaking changes
---
 src/api/handlers/guild.ts | 5 +++++
 src/api/handlers/mod.ts   | 2 ++
 src/util/constants.ts     | 3 +++
 3 files changed, 10 insertions(+)

diff --git a/src/api/handlers/guild.ts b/src/api/handlers/guild.ts
index b70e532ab..f290d4dc1 100644
--- a/src/api/handlers/guild.ts
+++ b/src/api/handlers/guild.ts
@@ -729,6 +729,11 @@ export function leaveGuild(guildID: string) {
   return RequestManager.delete(endpoints.GUILD_LEAVE(guildID));
 }
 
+/** Returns an array of voice regions that can be used when creating servers. */
+export function getAvailableVoiceRegions() {
+  return RequestManager.get(endpoints.VOICE_REGIONS);
+}
+
 /** Returns a list of voice region objects for the guild. Unlike the similar /voice route, this returns VIP servers when the guild is VIP-enabled. */
 export function getVoiceRegions(guildID: string) {
   return RequestManager.get(endpoints.GUILD_REGIONS(guildID));
diff --git a/src/api/handlers/mod.ts b/src/api/handlers/mod.ts
index c76b4227c..9d10d70f9 100644
--- a/src/api/handlers/mod.ts
+++ b/src/api/handlers/mod.ts
@@ -40,6 +40,7 @@ import {
   emojiURL,
   fetchMembers,
   getAuditLogs,
+  getAvailableVoiceRegions,
   getBan,
   getBans,
   getChannel,
@@ -171,6 +172,7 @@ export let handlers = {
   getGuildPreview,
   getGuildTemplate,
   getGuildTemplates,
+  getAvailableVoiceRegions,
   getIntegrations,
   getInvites,
   getMember,
diff --git a/src/util/constants.ts b/src/util/constants.ts
index bde99b4a8..03674cb29 100644
--- a/src/util/constants.ts
+++ b/src/util/constants.ts
@@ -117,6 +117,9 @@ export const endpoints = {
   GUILD_TEMPLATES: (guildID: string) => `${GUILDS_BASE(guildID)}/templates`,
   GUILD_PREVIEW: (guildID: string) => `${GUILDS_BASE(guildID)}/preview`,
 
+  // Voice
+  VOICE_REGIONS: `${baseEndpoints.BASE_URL}/voice/regions`,
+
   INVITE: (inviteCode: string) =>
     `${baseEndpoints.BASE_URL}/invites/${inviteCode}`,
 

From 55235e5ea06b0a5796ee963e7d957c564cc1e17f Mon Sep 17 00:00:00 2001
From: ITOH <72305210+itohatweb@users.noreply.github.com>
Date: Sat, 23 Jan 2021 20:17:50 +0100
Subject: [PATCH 4/6] feat(handlers): add getTemplate() (#422)

* feat(handlers): getTemplate

* update jsdoc

* redirect this function

* remove getGuildTemplate

* Update src/api/handlers/guild.ts

Co-authored-by: Ayyan <ayyantee@gmail.com>

* remove breaking change

* save in const

* Update src/api/handlers/guild.ts

Co-authored-by: Skillz4Killz <23035000+Skillz4Killz@users.noreply.github.com>

* Update src/api/handlers/guild.ts

* Update src/api/handlers/guild.ts

* Update mod.ts

Co-authored-by: Ayyan <ayyantee@gmail.com>
Co-authored-by: Skillz4Killz <23035000+Skillz4Killz@users.noreply.github.com>
---
 src/api/handlers/guild.ts | 16 +++++++++++++---
 src/api/handlers/mod.ts   |  2 ++
 2 files changed, 15 insertions(+), 3 deletions(-)

diff --git a/src/api/handlers/guild.ts b/src/api/handlers/guild.ts
index f290d4dc1..c57d6c810 100644
--- a/src/api/handlers/guild.ts
+++ b/src/api/handlers/guild.ts
@@ -772,13 +772,23 @@ export function getGuild(guildID: string, counts = true) {
 }
 
 /** Returns the guild template if it exists */
+export async function getTemplate(templateCode: string) {
+  const result = await RequestManager.get(
+    endpoints.GUILD_TEMPLATE(templateCode),
+  ) as GuildTemplate;
+  const template = await structures.createTemplate(result);
+  return template;
+}
+
+/** 
+ * Returns the guild template if it exists 
+ * @deprecated will get removed in v11 use `getTemplate` instead
+ */
 export function getGuildTemplate(
   guildID: string,
   templateCode: string,
 ) {
-  return RequestManager.get(
-    `${endpoints.GUILD_TEMPLATES(guildID)}/${templateCode}`,
-  ) as Promise<Template>;
+  return getTemplate(templateCode);
 }
 
 /**
diff --git a/src/api/handlers/mod.ts b/src/api/handlers/mod.ts
index 9d10d70f9..41ca9c21c 100644
--- a/src/api/handlers/mod.ts
+++ b/src/api/handlers/mod.ts
@@ -58,6 +58,7 @@ import {
   getMembersByQuery,
   getPruneCount,
   getRoles,
+  getTemplate,
   getUser,
   getVanityURL,
   getVoiceRegions,
@@ -176,6 +177,7 @@ export let handlers = {
   getIntegrations,
   getInvites,
   getMember,
+  getTemplate,
   getMembersByQuery,
   getPruneCount,
   getRoles,

From c2816659614a6af22eb5dffb1effbf824d8f1f08 Mon Sep 17 00:00:00 2001
From: ITOH <72305210+itohatweb@users.noreply.github.com>
Date: Sat, 23 Jan 2021 20:19:12 +0100
Subject: [PATCH 5/6] fix: use applicationID for slash commands instead of
 botID (#437)

* add(bot): ApplicationID let & setApplicationID function

* fix(controllers): set application id when bot is ready

* refactor(util): rename botID argument to applicationID

* fix(handlers): use applicationID
---
 src/api/controllers/misc.ts |  3 ++-
 src/api/handlers/webhook.ts | 34 +++++++++++++++++++---------------
 src/bot.ts                  |  6 ++++++
 src/util/constants.ts       | 20 ++++++++++++--------
 4 files changed, 39 insertions(+), 24 deletions(-)

diff --git a/src/api/controllers/misc.ts b/src/api/controllers/misc.ts
index da19bad3b..f3ff65254 100644
--- a/src/api/controllers/misc.ts
+++ b/src/api/controllers/misc.ts
@@ -1,4 +1,4 @@
-import { eventHandlers, setBotID } from "../../bot.ts";
+import { eventHandlers, setApplicationID, setBotID } from "../../bot.ts";
 import {
   DiscordPayload,
   PresenceUpdatePayload,
@@ -24,6 +24,7 @@ export async function handleInternalReady(
 
   const payload = data.d as ReadyPayload;
   setBotID(payload.user.id);
+  setApplicationID(payload.application.id);
 
   // Triggered on each shard
   eventHandlers.shardReady?.(shardID);
diff --git a/src/api/handlers/webhook.ts b/src/api/handlers/webhook.ts
index 12213c0ba..769f79fa7 100644
--- a/src/api/handlers/webhook.ts
+++ b/src/api/handlers/webhook.ts
@@ -1,4 +1,4 @@
-import { botID } from "../../bot.ts";
+import { applicationID } from "../../bot.ts";
 import { RequestManager } from "../../rest/request_manager.ts";
 import {
   CreateSlashCommandOptions,
@@ -206,8 +206,8 @@ export function createSlashCommand(options: CreateSlashCommandOptions) {
 
   return RequestManager.post(
     options.guildID
-      ? endpoints.COMMANDS_GUILD(botID, options.guildID)
-      : endpoints.COMMANDS(botID),
+      ? endpoints.COMMANDS_GUILD(applicationID, options.guildID)
+      : endpoints.COMMANDS(applicationID),
     {
       ...options,
     },
@@ -219,8 +219,8 @@ export function getSlashCommands(guildID?: string) {
   // TODO: Should this be a returned as a collection?
   return RequestManager.get(
     guildID
-      ? endpoints.COMMANDS_GUILD(botID, guildID)
-      : endpoints.COMMANDS(botID),
+      ? endpoints.COMMANDS_GUILD(applicationID, guildID)
+      : endpoints.COMMANDS(applicationID),
   );
 }
 
@@ -230,8 +230,8 @@ export function getSlashCommands(guildID?: string) {
 export function upsertSlashCommand(options: UpsertSlashCommandOptions) {
   return RequestManager.post(
     options.guildID
-      ? endpoints.COMMANDS_GUILD_ID(botID, options.id, options.guildID)
-      : endpoints.COMMANDS_ID(botID, options.id),
+      ? endpoints.COMMANDS_GUILD_ID(applicationID, options.id, options.guildID)
+      : endpoints.COMMANDS_ID(applicationID, options.id),
     {
       ...options,
     },
@@ -242,8 +242,8 @@ export function upsertSlashCommand(options: UpsertSlashCommandOptions) {
 export function editSlashCommand(options: EditSlashCommandOptions) {
   return RequestManager.patch(
     options.guildID
-      ? endpoints.COMMANDS_GUILD_ID(botID, options.id, options.guildID)
-      : endpoints.COMMANDS_ID(botID, options.id),
+      ? endpoints.COMMANDS_GUILD_ID(applicationID, options.id, options.guildID)
+      : endpoints.COMMANDS_ID(applicationID, options.id),
     {
       ...options,
     },
@@ -252,8 +252,12 @@ export function editSlashCommand(options: EditSlashCommandOptions) {
 
 /** Deletes a slash command. */
 export function deleteSlashCommand(id: string, guildID?: string) {
-  if (!guildID) return RequestManager.delete(endpoints.COMMANDS_ID(botID, id));
-  return RequestManager.delete(endpoints.COMMANDS_GUILD_ID(botID, id, guildID));
+  if (!guildID) {
+    return RequestManager.delete(endpoints.COMMANDS_ID(applicationID, id));
+  }
+  return RequestManager.delete(
+    endpoints.COMMANDS_GUILD_ID(applicationID, id, guildID),
+  );
 }
 
 /**
@@ -269,7 +273,7 @@ export function executeSlashCommand(
 ) {
   // If its already been executed, we need to send a followup response
   if (cache.executedSlashCommands.has(token)) {
-    return RequestManager.post(endpoints.WEBHOOK(botID, token), {
+    return RequestManager.post(endpoints.WEBHOOK(applicationID, token), {
       ...options,
     });
   }
@@ -298,11 +302,11 @@ export function deleteSlashResponse(
 ) {
   if (!messageID) {
     return RequestManager.delete(
-      endpoints.INTERACTION_ORIGINAL_ID_TOKEN(botID, token),
+      endpoints.INTERACTION_ORIGINAL_ID_TOKEN(applicationID, token),
     );
   }
   return RequestManager.delete(
-    endpoints.INTERACTION_ID_TOKEN_MESSAGEID(botID, token, messageID),
+    endpoints.INTERACTION_ID_TOKEN_MESSAGEID(applicationID, token, messageID),
   );
 }
 
@@ -312,7 +316,7 @@ export function editSlashResponse(
   options: EditSlashResponseOptions,
 ) {
   return RequestManager.patch(
-    endpoints.INTERACTION_ORIGINAL_ID_TOKEN(botID, token),
+    endpoints.INTERACTION_ORIGINAL_ID_TOKEN(applicationID, token),
     options,
   );
 }
diff --git a/src/bot.ts b/src/bot.ts
index b72475b6f..6cb39ead3 100644
--- a/src/bot.ts
+++ b/src/bot.ts
@@ -10,6 +10,7 @@ import { spawnShards } from "./ws/shard_manager.ts";
 
 export let authorization = "";
 export let botID = "";
+export let applicationID = "";
 
 export let eventHandlers: EventHandlers = {};
 
@@ -74,6 +75,11 @@ export function setBotID(id: string) {
   if (botID !== id) botID = id;
 }
 
+/** INTERNAL LIB function used to set the application ID once the READY event is sent by Discord. */
+export function setApplicationID(id: string) {
+  if (applicationID !== id) applicationID = id;
+}
+
 // BIG BRAIN BOT STUFF ONLY BELOW THIS
 
 /**
diff --git a/src/util/constants.ts b/src/util/constants.ts
index 03674cb29..a23292ba9 100644
--- a/src/util/constants.ts
+++ b/src/util/constants.ts
@@ -135,14 +135,18 @@ export const endpoints = {
     `${baseEndpoints.BASE_URL}/webhooks/${webhookID}/${token}/github`,
 
   // Application Endpoints
-  COMMANDS: (botID: string) =>
-    `${baseEndpoints.BASE_URL}/applications/${botID}/commands`,
-  COMMANDS_GUILD: (botID: string, guildID: string) =>
-    `${baseEndpoints.BASE_URL}/applications/${botID}/guilds/${guildID}/commands`,
-  COMMANDS_ID: (botID: string, commandID: string) =>
-    `${baseEndpoints.BASE_URL}/applications/${botID}/commands/${commandID}`,
-  COMMANDS_GUILD_ID: (botID: string, commandID: string, guildID: string) =>
-    `${baseEndpoints.BASE_URL}/applications/${botID}/guilds/${guildID}/commands/${commandID}`,
+  COMMANDS: (applicationID: string) =>
+    `${baseEndpoints.BASE_URL}/applications/${applicationID}/commands`,
+  COMMANDS_GUILD: (applicationID: string, guildID: string) =>
+    `${baseEndpoints.BASE_URL}/applications/${applicationID}/guilds/${guildID}/commands`,
+  COMMANDS_ID: (applicationID: string, commandID: string) =>
+    `${baseEndpoints.BASE_URL}/applications/${applicationID}/commands/${commandID}`,
+  COMMANDS_GUILD_ID: (
+    applicationID: string,
+    commandID: string,
+    guildID: string,
+  ) =>
+    `${baseEndpoints.BASE_URL}/applications/${applicationID}/guilds/${guildID}/commands/${commandID}`,
 
   // Interaction Endpoints
   INTERACTION_ID_TOKEN: (interactionID: string, token: string) =>

From 8d8c792747c8f5cae0e268755ee60dd7e63b53a4 Mon Sep 17 00:00:00 2001
From: ITOH <72305210+itohatweb@users.noreply.github.com>
Date: Sat, 23 Jan 2021 20:33:12 +0100
Subject: [PATCH 6/6] feat(handlers): add getInvite() & deleteInvite() (#421)

* feat(handlers): add getInvite

* feat(handlers): add deleteInvite

* remove deving things

* add jsdoc

* move functions up

* import got deleted

* feat(handlers): invite better types

* throw enum error

* remove unnecessary checks

* Update mod.ts

* channel exists since botHasChannelPermissions did not throw any error
---
 src/api/handlers/channel.ts | 35 +++++++++++++++++++++++++++++++++++
 src/api/handlers/mod.ts     |  4 ++++
 src/types/invite.ts         | 28 ++++++++++++++++++++++++++++
 src/types/mod.ts            |  1 +
 4 files changed, 68 insertions(+)
 create mode 100644 src/types/invite.ts

diff --git a/src/api/handlers/channel.ts b/src/api/handlers/channel.ts
index 118ca4e34..25ee577cc 100644
--- a/src/api/handlers/channel.ts
+++ b/src/api/handlers/channel.ts
@@ -9,6 +9,7 @@ import {
   GetMessagesAfter,
   GetMessagesAround,
   GetMessagesBefore,
+  InvitePayload,
   MessageContent,
   MessageCreateOptions,
   Permission,
@@ -19,6 +20,7 @@ import {
 import { endpoints } from "../../util/constants.ts";
 import {
   botHasChannelPermissions,
+  botHasPermission,
   calculateBits,
 } from "../../util/permissions.ts";
 import { cacheHandlers } from "../controllers/cache.ts";
@@ -301,6 +303,39 @@ export async function createInvite(
   return RequestManager.post(endpoints.CHANNEL_INVITES(channelID), options);
 }
 
+/** Returns an invite for the given code. */
+export function getInvite(inviteCode: string) {
+  return RequestManager.get(endpoints.INVITE(inviteCode)) as Promise<
+    InvitePayload
+  >;
+}
+
+/** Deletes an invite for the given code. Requires `MANAGE_CHANNELS` or `MANAGE_GUILD` permission */
+export async function deleteInvite(
+  channelID: string,
+  inviteCode: string,
+) {
+  const hasPerm = await botHasChannelPermissions(channelID, [
+    "MANAGE_CHANNELS",
+  ]);
+
+  if (!hasPerm) {
+    const channel = await cacheHandlers.get("channels", channelID);
+
+    const hasManageGuildPerm = await botHasPermission(channel!.guildID, [
+      "MANAGE_GUILD",
+    ]);
+
+    if (!hasManageGuildPerm) {
+      throw new Error(Errors.MISSING_MANAGE_CHANNELS);
+    }
+  }
+
+  return RequestManager.delete(endpoints.INVITE(inviteCode)) as Promise<
+    InvitePayload
+  >;
+}
+
 /** Gets the webhooks for this channel. Requires MANAGE_WEBHOOKS */
 export async function getChannelWebhooks(channelID: string) {
   const hasManageWebhooksPerm = await botHasChannelPermissions(
diff --git a/src/api/handlers/mod.ts b/src/api/handlers/mod.ts
index 41ca9c21c..06e7e2c5c 100644
--- a/src/api/handlers/mod.ts
+++ b/src/api/handlers/mod.ts
@@ -1,11 +1,13 @@
 import {
   channelOverwriteHasPermission,
   createInvite,
+  deleteInvite,
   deleteMessages,
   editChannel,
   followChannel,
   getChannelInvites,
   getChannelWebhooks,
+  getInvite,
   getMessage,
   getMessages,
   getPins,
@@ -133,6 +135,8 @@ export let handlers = {
   getPins,
   isChannelSynced,
   sendMessage,
+  getInvite,
+  deleteInvite,
   startTyping,
 
   // Gateway handler
diff --git a/src/types/invite.ts b/src/types/invite.ts
new file mode 100644
index 000000000..dd3789f55
--- /dev/null
+++ b/src/types/invite.ts
@@ -0,0 +1,28 @@
+import { Guild } from "../api/structures/mod.ts";
+import { ChannelCreatePayload } from "./channel.ts";
+import { UserPayload } from "./guild.ts";
+
+/** https://discord.com/developers/docs/resources/invite#invite-object */
+export interface InvitePayload {
+  /** the invite code (unique ID) */
+  code: string;
+  /** the guild this invite is for */
+  guild?: Partial<Guild>;
+  /** the channel this invite is for */
+  channel: Partial<ChannelCreatePayload>;
+  /** the user who created the invite */
+  inviter?: UserPayload;
+  /** the target user for this invite */
+  target_user?: Partial<UserPayload>;
+  /** the type of user target for this invite */
+  target_user_type?: InviteTargetUserTypes;
+  /** approximate count of online members (only present when target_user is set) */
+  approximate_presence_count?: number;
+  /** approximate count of total members */
+  approximate_member_count: number;
+}
+
+/** https://discord.com/developers/docs/resources/invite#invite-resource */
+export enum InviteTargetUserTypes {
+  STREAM = 1,
+}
diff --git a/src/types/mod.ts b/src/types/mod.ts
index edcb4c0f4..c4128d9d8 100644
--- a/src/types/mod.ts
+++ b/src/types/mod.ts
@@ -6,6 +6,7 @@ export * from "./errors.ts";
 export * from "./fetch.ts";
 export * from "./guild.ts";
 export * from "./interactions.ts";
+export * from "./invite.ts";
 export * from "./member.ts";
 export * from "./message.ts";
 export * from "./options.ts";