From fd82b12c170eda28f129cdc87cbbb095d521d28e Mon Sep 17 00:00:00 2001
From: Jonathan Ho <48591478+H01001000@users.noreply.github.com>
Date: Sun, 30 Oct 2022 03:45:58 +0800
Subject: [PATCH] Fix Ci (#2565)

* fix: Validate not running cron

* fix: always upload artifact

* fix: generate fail on first comment
---
 .github/workflows/benchmark.yml     |  1 -
 .github/workflows/validateCache.yml | 19 +++++++++++++++++--
 performance/generateMessage.ts      | 18 ++++++++++--------
 3 files changed, 27 insertions(+), 11 deletions(-)

diff --git a/.github/workflows/benchmark.yml b/.github/workflows/benchmark.yml
index 595785245..5294ab8bf 100644
--- a/.github/workflows/benchmark.yml
+++ b/.github/workflows/benchmark.yml
@@ -42,7 +42,6 @@ jobs:
           output-file-path: output.txt
           external-data-json-path: benchmarksResult/data.json
       - uses: actions/upload-artifact@v3
-        if: ${{ github.ref != 'refs/heads/main' }}
         with:
           name: benchmarkResults
           path: benchmarksResult/data.json
diff --git a/.github/workflows/validateCache.yml b/.github/workflows/validateCache.yml
index ab5f445a9..da69fcb1c 100644
--- a/.github/workflows/validateCache.yml
+++ b/.github/workflows/validateCache.yml
@@ -1,12 +1,27 @@
 name: Validate Cache
 
 on:
+  schedule:
+    - cron: "0 0 * * *"
   workflow_dispatch:
 
-# This is just a dummy action for real one in benchies branch to run
 jobs:
   validate-cache:
     name: Validate Cache
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
+        with:
+          ref: "benchies"
+      - uses: denoland/setup-deno@main
+        with:
+          deno-version: "v1.x"
+      - name: Check And Update Objects
+        run: deno run -A cache/checkAndUpdateObjects.ts
+        env:
+          DISCORD_TOKEN: ${{ secrets.DISCORD_TOKEN }}
+      - name: Commit and push
+        uses: EndBug/add-and-commit@v9
+        with:
+          add: cache/cachedObject
+          message: "[Scheduled] Auto patch objects"
diff --git a/performance/generateMessage.ts b/performance/generateMessage.ts
index 005b818f5..862cb0e48 100644
--- a/performance/generateMessage.ts
+++ b/performance/generateMessage.ts
@@ -36,8 +36,8 @@ interface CompareTable {
 }
 
 const benchmarks = results.entries.Benchmark.slice(-2) as BenchmarksData[];
-const latestHeadBenchmarks = benchmarks[1];
-const lastHeadBenchmarks = benchmarks[0];
+const latestHeadBenchmarks = benchmarks.length === 2 ? benchmarks[1] : benchmarks[0];
+const lastHeadBenchmarks = benchmarks.length === 2 ? benchmarks[0] : undefined;
 //@ts-ignore
 const latestBaseBenchmarks = JSON.parse(JSON.stringify(window.BENCHMARK_DATA.entries.Benchmark)).slice(
   -1,
@@ -46,11 +46,13 @@ const latestBaseBenchmarks = JSON.parse(JSON.stringify(window.BENCHMARK_DATA.ent
 const compareWithHead: CompareTable = {};
 const compareWithBase: CompareTable = {};
 
-for (const benchmark of lastHeadBenchmarks.benches) {
-  compareWithHead[benchmark.name] = {
-    previous: benchmark,
-    current: {},
-  };
+if (lastHeadBenchmarks) {
+  for (const benchmark of lastHeadBenchmarks.benches) {
+    compareWithHead[benchmark.name] = {
+      previous: benchmark,
+      current: {},
+    };
+  }
 }
 for (const benchmark of latestBaseBenchmarks.benches) {
   compareWithBase[benchmark.name] = {
@@ -75,7 +77,7 @@ for (const benchmark of latestHeadBenchmarks.benches) {
 
 let message = "";
 
-const compareTableInfo = [{ name: "last head", commit: lastHeadBenchmarks.commit.id }, {
+const compareTableInfo = [{ name: "last head", commit: lastHeadBenchmarks ? lastHeadBenchmarks.commit.id : "" }, {
   name: "base",
   commit: latestBaseBenchmarks.commit.id,
 }];