fix channel permission thing

src/helpers/channels/clone_channel.ts

@@ -13,8 +13,8 @@ export async function cloneChannel(channelId: string, reason?: string) {
 
   //Check for DM channel
   if (
-    channelToClone.type === DiscordChannelTypes.DM ||
-    channelToClone.type === DiscordChannelTypes.GROUP_DM
+    channelToClone.type === DiscordChannelTypes.Dm ||
+    channelToClone.type === DiscordChannelTypes.GroupDm
   ) {
     throw new Error(Errors.CHANNEL_NOT_IN_GUILD);
   }

src/helpers/channels/create_channel.ts

@@ -1,4 +1,3 @@
-import { eventHandlers } from "../../bot.ts";
 import { cacheHandlers } from "../../cache.ts";
 import { rest } from "../../rest/rest.ts";
 import { structures } from "../../structures/mod.ts";
@@ -8,11 +7,10 @@ import {
   CreateGuildChannel,
   DiscordCreateGuildChannel,
 } from "../../types/guilds/create_guild_channel.ts";
-import { PermissionStrings } from "../../types/permissions/permission_strings.ts";
 import { endpoints } from "../../util/constants.ts";
 import {
   calculateBits,
-  requireBotGuildPermissions,
+  requireOverwritePermissions,
 } from "../../util/permissions.ts";
 import { camelKeysToSnakeCase } from "../../util/utils.ts";
 
@@ -22,18 +20,12 @@ export async function createChannel(
   options?: CreateGuildChannel,
   reason?: string,
 ) {
-  const requiredPerms: Set<PermissionStrings> = new Set(["MANAGE_CHANNELS"]);
-
-  options?.permissionOverwrites?.forEach((overwrite) => {
-    eventHandlers.debug?.(
-      "loop",
-      `Running forEach loop in create_channel file.`,
+  if (options?.permissionOverwrites) {
+    await requireOverwritePermissions(
+      guildId,
+      options.permissionOverwrites,
     );
-    overwrite.allow.forEach(requiredPerms.add, requiredPerms);
-    overwrite.deny.forEach(requiredPerms.add, requiredPerms);
-  });
-
-  await requireBotGuildPermissions(guildId, [...requiredPerms]);
+  }
 
   // BITRATES ARE IN THOUSANDS SO IF USER PROVIDES 32 WE CONVERT TO 32000
   if (options?.bitrate && options.bitrate < 1000) options.bitrate *= 1000;
@@ -48,7 +40,7 @@ export async function createChannel(
         allow: calculateBits(perm.allow),
         deny: calculateBits(perm.deny),
       })),
-      type: options?.type || DiscordChannelTypes.GUILD_TEXT,
+      type: options?.type || DiscordChannelTypes.GuildText,
       reason,
     },
   );

src/helpers/channels/edit_channel.ts

@@ -1,20 +1,27 @@
 import { eventHandlers } from "../../bot.ts";
+import { cacheHandlers } from "../../cache.ts";
 import { rest } from "../../rest/rest.ts";
 import { ModifyChannel } from "../../types/channels/modify_channel.ts";
 import { Channel } from "../../types/mod.ts";
 import { endpoints } from "../../util/constants.ts";
 import {
   calculateBits,
-  requireBotChannelPermissions,
+  requireOverwritePermissions,
 } from "../../util/permissions.ts";
-
+//TODO: implement DM group channel edit
 /** Update a channel's settings. Requires the `MANAGE_CHANNELS` permission for the guild. */
 export async function editChannel(
   channelId: string,
   options: ModifyChannel,
   reason?: string,
 ) {
-  await requireBotChannelPermissions(channelId, ["MANAGE_CHANNELS"]);
+  const channel = await cacheHandlers.get("channels", channelId);
+  if (channel?.guildId) {
+    await requireOverwritePermissions(
+      channel.guildId,
+      options.permissionOverwrites || [],
+    );
+  }
 
   if (options.name || options.topic) {
     const request = editChannelNameTopicQueue.get(channelId);