fix(misc): check whether guilds' loaded every 2s (#353)

* fix(misc): check whether guilds' loaded every 2s

* unavailable_guilds -> guilds

* guilds -> unavailable_guilds

* Separate unavailable guild  type

* Clean up and apply suggested changes

src/api/controllers/misc.ts

@@ -28,17 +28,26 @@ export async function handleInternalReady(
   // Triggered on each shard
   eventHandlers.shardReady?.(shardID);
   if (payload.shard && shardID === payload.shard[1] - 1) {
-    // Wait for 5 seconds to allow all guild create events to be processed
-    await delay(5000);
-    cache.isReady = true;
-    eventHandlers.ready?.();
+    const loadedAllGuilds = async () => {
+      if (payload.guilds.some((g) => !cache.guilds.has(g.id))) {
+        setTimeout(() => loadedAllGuilds, 2000);
+      } else {
+        // The bot has already started, the last shard is resumed, however.
+        if (cache.isReady) return;
 
-    // All the members that came in on guild creates should now be processed 1 by 1
-    for (const [guildID, members] of initialMemberLoadQueue.entries()) {
-      await Promise.all(
-        members.map((member) => structures.createMember(member, guildID)),
-      );
-    }
+        cache.isReady = true;
+        eventHandlers.ready?.();
+
+        // All the members that came in on guild creates should now be processed 1 by 1
+        for (const [guildID, members] of initialMemberLoadQueue.entries()) {
+          await Promise.all(
+            members.map((member) => structures.createMember(member, guildID)),
+          );
+        }
+      }
+    };
+
+    setTimeout(() => loadedAllGuilds(), 2000);
   }
 
   // Wait 5 seconds to spawn next shard

src/api/handlers/webhook.ts

@@ -46,7 +46,7 @@ export async function createWebhook(
     throw new Error(Errors.INVALID_WEBHOOK_NAME);
   }
 
-  return await RequestManager.post(
+  return RequestManager.post(
     endpoints.CHANNEL_WEBHOOKS(channelID),
     {
       ...options,