fix: use applicationID for slash commands instead of botID (#437)

* add(bot): ApplicationID let & setApplicationID function

* fix(controllers): set application id when bot is ready

* refactor(util): rename botID argument to applicationID

* fix(handlers): use applicationID

src/api/controllers/misc.ts

@@ -1,4 +1,4 @@
-import { eventHandlers, setBotID } from "../../bot.ts";
+import { eventHandlers, setApplicationID, setBotID } from "../../bot.ts";
 import {
   DiscordPayload,
   PresenceUpdatePayload,
@@ -24,6 +24,7 @@ export async function handleInternalReady(
 
   const payload = data.d as ReadyPayload;
   setBotID(payload.user.id);
+  setApplicationID(payload.application.id);
 
   // Triggered on each shard
   eventHandlers.shardReady?.(shardID);

src/api/handlers/webhook.ts

@@ -1,4 +1,4 @@
-import { botID } from "../../bot.ts";
+import { applicationID } from "../../bot.ts";
 import { RequestManager } from "../../rest/request_manager.ts";
 import {
   CreateSlashCommandOptions,
@@ -206,8 +206,8 @@ export function createSlashCommand(options: CreateSlashCommandOptions) {
 
   return RequestManager.post(
     options.guildID
-      ? endpoints.COMMANDS_GUILD(botID, options.guildID)
-      : endpoints.COMMANDS(botID),
+      ? endpoints.COMMANDS_GUILD(applicationID, options.guildID)
+      : endpoints.COMMANDS(applicationID),
     {
       ...options,
     },
@@ -219,8 +219,8 @@ export function getSlashCommands(guildID?: string) {
   // TODO: Should this be a returned as a collection?
   return RequestManager.get(
     guildID
-      ? endpoints.COMMANDS_GUILD(botID, guildID)
-      : endpoints.COMMANDS(botID),
+      ? endpoints.COMMANDS_GUILD(applicationID, guildID)
+      : endpoints.COMMANDS(applicationID),
   );
 }
 
@@ -230,8 +230,8 @@ export function getSlashCommands(guildID?: string) {
 export function upsertSlashCommand(options: UpsertSlashCommandOptions) {
   return RequestManager.post(
     options.guildID
-      ? endpoints.COMMANDS_GUILD_ID(botID, options.id, options.guildID)
-      : endpoints.COMMANDS_ID(botID, options.id),
+      ? endpoints.COMMANDS_GUILD_ID(applicationID, options.id, options.guildID)
+      : endpoints.COMMANDS_ID(applicationID, options.id),
     {
       ...options,
     },
@@ -242,8 +242,8 @@ export function upsertSlashCommand(options: UpsertSlashCommandOptions) {
 export function editSlashCommand(options: EditSlashCommandOptions) {
   return RequestManager.patch(
     options.guildID
-      ? endpoints.COMMANDS_GUILD_ID(botID, options.id, options.guildID)
-      : endpoints.COMMANDS_ID(botID, options.id),
+      ? endpoints.COMMANDS_GUILD_ID(applicationID, options.id, options.guildID)
+      : endpoints.COMMANDS_ID(applicationID, options.id),
     {
       ...options,
     },
@@ -252,8 +252,12 @@ export function editSlashCommand(options: EditSlashCommandOptions) {
 
 /** Deletes a slash command. */
 export function deleteSlashCommand(id: string, guildID?: string) {
-  if (!guildID) return RequestManager.delete(endpoints.COMMANDS_ID(botID, id));
-  return RequestManager.delete(endpoints.COMMANDS_GUILD_ID(botID, id, guildID));
+  if (!guildID) {
+    return RequestManager.delete(endpoints.COMMANDS_ID(applicationID, id));
+  }
+  return RequestManager.delete(
+    endpoints.COMMANDS_GUILD_ID(applicationID, id, guildID),
+  );
 }
 
 /**
@@ -269,7 +273,7 @@ export function executeSlashCommand(
 ) {
   // If its already been executed, we need to send a followup response
   if (cache.executedSlashCommands.has(token)) {
-    return RequestManager.post(endpoints.WEBHOOK(botID, token), {
+    return RequestManager.post(endpoints.WEBHOOK(applicationID, token), {
       ...options,
     });
   }
@@ -298,11 +302,11 @@ export function deleteSlashResponse(
 ) {
   if (!messageID) {
     return RequestManager.delete(
-      endpoints.INTERACTION_ORIGINAL_ID_TOKEN(botID, token),
+      endpoints.INTERACTION_ORIGINAL_ID_TOKEN(applicationID, token),
     );
   }
   return RequestManager.delete(
-    endpoints.INTERACTION_ID_TOKEN_MESSAGEID(botID, token, messageID),
+    endpoints.INTERACTION_ID_TOKEN_MESSAGEID(applicationID, token, messageID),
   );
 }
 
@@ -312,7 +316,7 @@ export function editSlashResponse(
   options: EditSlashResponseOptions,
 ) {
   return RequestManager.patch(
-    endpoints.INTERACTION_ORIGINAL_ID_TOKEN(botID, token),
+    endpoints.INTERACTION_ORIGINAL_ID_TOKEN(applicationID, token),
     options,
   );
 }

src/bot.ts

@@ -10,6 +10,7 @@ import { spawnShards } from "./ws/shard_manager.ts";
 
 export let authorization = "";
 export let botID = "";
+export let applicationID = "";
 
 export let eventHandlers: EventHandlers = {};
 
@@ -74,6 +75,11 @@ export function setBotID(id: string) {
   if (botID !== id) botID = id;
 }
 
+/** INTERNAL LIB function used to set the application ID once the READY event is sent by Discord. */
+export function setApplicationID(id: string) {
+  if (applicationID !== id) applicationID = id;
+}
+
 // BIG BRAIN BOT STUFF ONLY BELOW THIS
 
 /**

src/util/constants.ts

@@ -135,14 +135,18 @@ export const endpoints = {
     `${baseEndpoints.BASE_URL}/webhooks/${webhookID}/${token}/github`,
 
   // Application Endpoints
-  COMMANDS: (botID: string) =>
-    `${baseEndpoints.BASE_URL}/applications/${botID}/commands`,
-  COMMANDS_GUILD: (botID: string, guildID: string) =>
-    `${baseEndpoints.BASE_URL}/applications/${botID}/guilds/${guildID}/commands`,
-  COMMANDS_ID: (botID: string, commandID: string) =>
-    `${baseEndpoints.BASE_URL}/applications/${botID}/commands/${commandID}`,
-  COMMANDS_GUILD_ID: (botID: string, commandID: string, guildID: string) =>
-    `${baseEndpoints.BASE_URL}/applications/${botID}/guilds/${guildID}/commands/${commandID}`,
+  COMMANDS: (applicationID: string) =>
+    `${baseEndpoints.BASE_URL}/applications/${applicationID}/commands`,
+  COMMANDS_GUILD: (applicationID: string, guildID: string) =>
+    `${baseEndpoints.BASE_URL}/applications/${applicationID}/guilds/${guildID}/commands`,
+  COMMANDS_ID: (applicationID: string, commandID: string) =>
+    `${baseEndpoints.BASE_URL}/applications/${applicationID}/commands/${commandID}`,
+  COMMANDS_GUILD_ID: (
+    applicationID: string,
+    commandID: string,
+    guildID: string,
+  ) =>
+    `${baseEndpoints.BASE_URL}/applications/${applicationID}/guilds/${guildID}/commands/${commandID}`,
 
   // Interaction Endpoints
   INTERACTION_ID_TOKEN: (interactionID: string, token: string) =>