From 43393f1a5da38b7ed160b76c6aef9317f3d67e24 Mon Sep 17 00:00:00 2001
From: LTS20050703 <lts20050703@gmail.com>
Date: Sun, 4 Sep 2022 23:31:36 +0700
Subject: [PATCH] BREAKING: banMember deleteMessageDays > deleteMessageSeconds
 (#2422)

* add ban delete_message_seconds and remove reason

* test: ban member and delete messages

* helpers/banMember: nuke deleteMessageDays

Co-authored-by: Skillz4Killz <23035000+Skillz4Killz@users.noreply.github.com>
---
 helpers/members/banMember.ts      | 14 ++++++--------
 tests/guilds/members/bans.test.ts | 10 +++++++++-
 2 files changed, 15 insertions(+), 9 deletions(-)

diff --git a/helpers/members/banMember.ts b/helpers/members/banMember.ts
index 3b5a150df..693f7580c 100644
--- a/helpers/members/banMember.ts
+++ b/helpers/members/banMember.ts
@@ -6,19 +6,17 @@ export async function banMember(bot: Bot, guildId: bigint, id: bigint, options?:
     bot.rest,
     "PUT",
     bot.constants.routes.GUILD_BAN(guildId, id),
-    options
-      ? {
-        delete_message_days: options.deleteMessageDays,
-        reason: options.reason,
-      }
-      : {},
+    {
+      delete_message_seconds: options?.deleteMessageSeconds,
+      reason: options?.reason,
+    },
   );
 }
 
 /** https://discord.com/developers/docs/resources/guild#create-guild-ban */
 export interface CreateGuildBan {
-  /** Number of days to delete messages for (0-7) */
-  deleteMessageDays?: 0 | 1 | 2 | 3 | 4 | 5 | 6 | 7;
+  /** Number of seconds to delete messages for, between 0 and 604800 (7 days) */
+  deleteMessageSeconds?: number;
   /** Reason for the ban */
   reason?: string;
 }
diff --git a/tests/guilds/members/bans.test.ts b/tests/guilds/members/bans.test.ts
index 2f8f4f06b..e3299d7a9 100644
--- a/tests/guilds/members/bans.test.ts
+++ b/tests/guilds/members/bans.test.ts
@@ -4,8 +4,10 @@ import { CACHED_COMMUNITY_GUILD_ID } from "../../utils.ts";
 
 // THIS IS WOLF, IF ANYTHING BREAKS BLAME HIM!
 const wolfID = 270273690074087427n;
-// THIS IS IAN, HE PLAY'S GOLDEN SUN. BAN BEFORE HE MAKES US ADDICTED TO IT!!!
+// THIS IS IAN, HE PLAY GOLDEN SUN. BAN HIM BEFORE HE MAKES US ADDICTED TO IT!!!
 const ianID = 90339695967350784n;
+// THIS IS LTS, HE PLAY TETRIS EFFECT: CONNECTED. BAN HIM BEFORE HE MAKES US ADDICTED TO IT!!!
+const ltsID = 379643682984296448n;
 
 // THESE BAN TESTS SHOULD BE DONE ONE BY ONE
 Deno.test({
@@ -38,6 +40,12 @@ Deno.test({
       },
     });
 
+    // ban member from guild and delete messages
+    await t.step("[member] ban member from guild and delete messages", async () => {
+      await bot.helpers.banMember(CACHED_COMMUNITY_GUILD_ID, ltsID, { deleteMessageSeconds: 604800 });
+      assertExists(await bot.helpers.getBan(CACHED_COMMUNITY_GUILD_ID, ltsID));
+    });
+
     // get bans on a server
     await t.step({
       name: "[member] get bans on a server",