formatter: Use semicolons (#4686)

I prefer semicolors, they also help avoiding certain pitfalls in JavaScript/TypeScript, such as the following code sample:
```js
const xyz = "test"
(something.else as string) = "another"
```
This results in a TypeError: "test" is not a function, this is because js thinks we are trying to call the string "test" as a function.
To fix this it requires a `;` somewhere before the `(`, such as `;(something ... ` which in my opinion is ugly and less clean overall.
This commit is contained in:
Fleny
2026-01-17 21:54:15 +01:00
committed by GitHub
parent f713b4ab7b
commit 27c261fee2
403 changed files with 11250 additions and 11217 deletions
+31 -31
View File
@@ -1,6 +1,6 @@
import { ApplicationCommandOptionTypes } from '@discordeno/types'
import type { CompleteDesiredProperties, DesiredPropertiesBehavior, SetupDesiredProps, TransformersDesiredProperties } from './desiredProperties.js'
import type { Attachment, Channel, Interaction, InteractionDataOption, Member, Role, User } from './transformers/types.js'
import { ApplicationCommandOptionTypes } from '@discordeno/types';
import type { CompleteDesiredProperties, DesiredPropertiesBehavior, SetupDesiredProps, TransformersDesiredProperties } from './desiredProperties.js';
import type { Attachment, Channel, Interaction, InteractionDataOption, Member, Role, User } from './transformers/types.js';
export function commandOptionsParser<
TProps extends TransformersDesiredProperties & { interaction: { data: true } },
@@ -11,51 +11,51 @@ export function commandOptionsParser<
Interaction,
CompleteDesiredProperties<{ interaction: { data: true } }>,
DesiredPropertiesBehavior.RemoveKey
>
>;
if (!interaction.data) return {}
if (!options) options = interaction.data.options ?? []
if (!interaction.data) return {};
if (!options) options = interaction.data.options ?? [];
const args: ParsedInteractionOption<TProps, TBehavior> = {}
const args: ParsedInteractionOption<TProps, TBehavior> = {};
for (const option of options) {
switch (option.type) {
case ApplicationCommandOptionTypes.SubCommandGroup:
case ApplicationCommandOptionTypes.SubCommand:
args[option.name] = commandOptionsParser(interaction, option.options) as InteractionResolvedData<TProps, TBehavior>
break
args[option.name] = commandOptionsParser(interaction, option.options) as InteractionResolvedData<TProps, TBehavior>;
break;
case ApplicationCommandOptionTypes.Channel:
args[option.name] = interaction.data.resolved?.channels?.get(BigInt(option.value!)) as InteractionResolvedData<TProps, TBehavior>
break
args[option.name] = interaction.data.resolved?.channels?.get(BigInt(option.value!)) as InteractionResolvedData<TProps, TBehavior>;
break;
case ApplicationCommandOptionTypes.Role:
args[option.name] = interaction.data.resolved?.roles?.get(BigInt(option.value!)) as InteractionResolvedData<TProps, TBehavior>
break
args[option.name] = interaction.data.resolved?.roles?.get(BigInt(option.value!)) as InteractionResolvedData<TProps, TBehavior>;
break;
case ApplicationCommandOptionTypes.User:
args[option.name] = {
user: interaction.data.resolved?.users?.get(BigInt(option.value!)) as InteractionResolvedData<TProps, TBehavior>,
member: interaction.data.resolved?.members?.get(BigInt(option.value!)) as InteractionResolvedData<TProps, TBehavior>,
}
break
};
break;
case ApplicationCommandOptionTypes.Attachment:
args[option.name] = interaction.data.resolved?.attachments?.get(BigInt(option.value!)) as InteractionResolvedData<TProps, TBehavior>
break
args[option.name] = interaction.data.resolved?.attachments?.get(BigInt(option.value!)) as InteractionResolvedData<TProps, TBehavior>;
break;
case ApplicationCommandOptionTypes.Mentionable:
// Mentionable are roles or users
args[option.name] = (interaction.data.resolved?.roles?.get(BigInt(option.value!)) as ParsedInteractionOption<TProps, TBehavior>[string]) ?? {
user: interaction.data.resolved?.users?.get(BigInt(option.value!)) as InteractionResolvedData<TProps, TBehavior>,
member: interaction.data.resolved?.members?.get(BigInt(option.value!)) as InteractionResolvedData<TProps, TBehavior>,
}
break
};
break;
default:
args[option.name] = option.value as InteractionResolvedData<TProps, TBehavior>
args[option.name] = option.value as InteractionResolvedData<TProps, TBehavior>;
}
}
return args
return args;
}
export interface ParsedInteractionOption<TProps extends TransformersDesiredProperties, TBehavior extends DesiredPropertiesBehavior> {
[key: string]: InteractionResolvedData<TProps, TBehavior>
[key: string]: InteractionResolvedData<TProps, TBehavior>;
}
export type InteractionResolvedData<TProps extends TransformersDesiredProperties, TBehavior extends DesiredPropertiesBehavior> =
@@ -66,11 +66,11 @@ export type InteractionResolvedData<TProps extends TransformersDesiredProperties
| InteractionResolvedDataChannel<TProps, TBehavior>
| SetupDesiredProps<Role, TProps, TBehavior>
| SetupDesiredProps<Attachment, TProps, TBehavior>
| ParsedInteractionOption<TProps, TBehavior>
| ParsedInteractionOption<TProps, TBehavior>;
export interface InteractionResolvedDataUser<TProps extends TransformersDesiredProperties, TBehavior extends DesiredPropertiesBehavior> {
user: SetupDesiredProps<User, TProps, TBehavior>
member: InteractionResolvedDataMember<TProps, TBehavior>
user: SetupDesiredProps<User, TProps, TBehavior>;
member: InteractionResolvedDataMember<TProps, TBehavior>;
}
export type InteractionResolvedDataChannel<TProps extends TransformersDesiredProperties, TBehavior extends DesiredPropertiesBehavior> = Pick<
@@ -92,17 +92,17 @@ export type InteractionResolvedDataChannel<TProps extends TransformersDesiredPro
| 'position'
| 'threadMetadata'
>
>
>;
export type InteractionResolvedDataMember<TProps extends TransformersDesiredProperties, TBehavior extends DesiredPropertiesBehavior> = Omit<
SetupDesiredProps<Member, TProps, TBehavior>,
'user' | 'deaf' | 'mute'
>
>;
/** @deprecated Use {@link InteractionResolvedDataUser} */
export interface InteractionResolvedUser {
user: User
member: InteractionResolvedMember
user: User;
member: InteractionResolvedMember;
}
/** @deprecated Use {@link InteractionResolvedDataChannel} */
@@ -122,7 +122,7 @@ export type InteractionResolvedChannel = Pick<
| 'topic'
| 'position'
| 'threadMetadata'
>
>;
/** @deprecated Use {@link InteractionResolvedDataMember} */
export type InteractionResolvedMember = Omit<Member, 'user' | 'deaf' | 'mute'>
export type InteractionResolvedMember = Omit<Member, 'user' | 'deaf' | 'mute'>;