Commit Graph

2451 Commits

Author SHA1 Message Date
isonmad e9fa8a438c fix Client.destroy bugs (#828)
* add test for Client.destroy()

* propagate errors in ClientManager.destroy

If the promise returned by logout() rejects, previously
it would be completely uncaught, and just return an
eternally pending promise that never resolved.

* fix RESTMethods.logout

Without a data argument, the POST that superagent sends causes
the discord server to reply with a HTTP 400 error:

text: '{"Content-Type": "Expected Content-Type to be one of set([\'application/json\'])."}',

* fix Client.destroy

_timeouts and _intervals were changed to Set objects in
commit 6ede7a32fd a month ago.

Changing them to arrays causes failures if you try to reuse
the client object again.

* always close websocket in ClientManager.destroy

Invoking logout does not implicitly cause the server to close
the websocket for you, so cleanup everything.

Otherwise the websocket being open keeps node alive and hanging
mysteriously until the connection hits a timeout.

* fix indentation for eslint
2016-10-26 14:49:45 +01:00
Amish Shah 26de908cfd some voice docs 2016-10-26 14:44:19 +01:00
Amish Shah 968883ec35 Merge branch 'indev' of https://github.com/hydrabolt/discord.js into indev 2016-10-26 14:19:39 +01:00
Amish Shah 0c4a4023ce Fix setting guild role positions (#751) 2016-10-26 14:19:36 +01:00
Schuyler Cebulskie 05f73c3edf Clean up voice channel join permissions check 2016-10-25 20:41:23 -04:00
Schuyler Cebulskie b2a4545c16 Clean up more voice stuff 2016-10-25 20:34:57 -04:00
Schuyler Cebulskie d1e9d15a1c Clean up a bunch of new voice stuff 2016-10-25 20:26:57 -04:00
Schuyler Cebulskie a04094f0ff Rename VoiceConnection.disconnected event -> disconnect 2016-10-25 19:59:22 -04:00
Schuyler Cebulskie c96d5ad30e Optimise everyone/here replacing 2016-10-25 19:01:56 -04:00
Schuyler Cebulskie 526430b51a Revert "Fix #837"
This reverts commit add52ce62d.
2016-10-25 18:49:12 -04:00
Amish Shah add52ce62d Fix #837 2016-10-25 22:03:04 +01:00
Amish Shah ff16c9f01f change currentDispatcher to just dispatcher 2016-10-25 21:55:38 +01:00
Amish Shah 0f8e8dddff fix presence updating 2016-10-25 21:40:53 +01:00
Amish Shah 2ee6da8d79 redo docs again 2016-10-25 19:52:10 +01:00
Amish Shah 5bd18e6051 add some documentation 2016-10-25 19:47:17 +01:00
Amish Shah f77af72d71 Add voice receiving again \o/ 2016-10-25 19:41:54 +01:00
Amish Shah b50bec8a44 whoops broke travis again 2016-10-25 15:02:16 +01:00
Amish Shah 2b2bbb565d don't require longjohn 2016-10-25 14:46:50 +01:00
Amish Shah 5844bbb54c Fix travis builds 2016-10-25 14:38:56 +01:00
Amish Shah 91ba59c43d Added voice disconnect 2016-10-25 14:18:20 +01:00
Amish Shah b0921ae0ef fix econnreset! \o/ #694 2016-10-25 12:52:07 +01:00
Amish Shah 823a339c25 oh no wait i was right the first time 2016-10-24 22:27:23 +01:00
Amish Shah 8a68fea9af damn it hydar 2016-10-24 22:27:03 +01:00
Amish Shah d73d6a7340 make some stuffs 2016-10-24 22:26:34 +01:00
Amish Shah f96c185d92 add the functions to voice connection 2016-10-24 21:39:32 +01:00
Amish Shah 1a5ce878a1 fix some stuff 2016-10-24 20:13:44 +01:00
Amish Shah 5749eb6bb0 actually log the damn reason 2016-10-24 18:56:02 +01:00
Amish Shah 7818d37042 catch cleanup reasons 2016-10-24 18:36:52 +01:00
Amish Shah 17586f0e20 maybe fix again 2016-10-24 17:41:37 +01:00
Amish Shah c6d0c31c84 hydra have you actually fixed voice whatttt 2016-10-24 17:10:17 +01:00
Amish Shah b24e0b347e Merge remote-tracking branch 'origin/indev' into indev-voice 2016-10-24 16:26:41 +01:00
Amish Shah 6093dac554 Fix #776 (guildMemberAdd firing for existing members) 2016-10-24 15:57:07 +01:00
Amish Shah d42ac98339 Fix #775 (permission overwrites not taking into account previous values) 2016-10-24 15:47:31 +01:00
Amish Shah 9d0dd665de fix something 2016-10-24 14:49:01 +01:00
Amish Shah 8dd2005ab9 stop logging 2016-10-24 14:37:08 +01:00
Amish Shah e13e2447d4 get voice sort of working 2016-10-24 14:26:24 +01:00
Amish Shah 9b3dd540ef Merge remote-tracking branch 'origin/indev' into indev-voice 2016-10-24 12:50:40 +01:00
Schuyler Cebulskie c5c9d0265c Evie 😒 2016-10-24 01:10:52 -04:00
Gus Caplan 44bae385c2 update clientUser#setAvatar (#819)
* WHO DID THIS

* e

* some people have base64 fetishes i guess

Signed-off-by: Gus Caplan <fluffyrobotcheese@gmail.com>
2016-10-24 01:09:38 -04:00
Évelyne Lachance 478377ac52 Merge pull request #830 from eslachance/indev
Version bump for indev+troubleshooting
2016-10-24 01:05:07 -04:00
Evelyne Lachance a7d16e66b7 Version bump for indev+troubleshooting 2016-10-24 00:50:15 -04:00
Amish Shah c86ff6ad1a Merge branch 'indev' of https://github.com/hydrabolt/discord.js into indev 2016-10-23 20:51:07 +01:00
Amish Shah 21533eec5b fix banning probably hopefully 2016-10-23 20:51:04 +01:00
Amish Shah b2eb796cfc remove console.log and fix endless loop connecting 2016-10-23 19:59:19 +01:00
Schuyler Cebulskie c9c6e8a357 Added note about bot accounts to fetchMessage 2016-10-23 14:59:04 -04:00
Gus Caplan 3e1425af04 allow TextBasedChannel#bulkDelete to take a number (#821)
* useful

* update docs

* Update TextBasedChannel.js

* update docs

* fix docs

* Update TextBasedChannel.js
2016-10-23 14:51:54 -04:00
Amish Shah 38ff53c3a1 woah is hydra actually working on voice?! 2016-10-23 19:51:44 +01:00
Amish Shah f3439dcf6d Merge remote-tracking branch 'origin/indev' into indev-voice 2016-10-23 14:46:41 +01:00
Gus Caplan b020fae258 fix emoji updates (#826) 2016-10-22 23:43:07 -04:00
Gus Caplan 422b90c711 add way more friend shit (#815) 2016-10-22 16:25:55 -04:00