From 70bab5d1b268c281c2846f14e50eee9bbb966b28 Mon Sep 17 00:00:00 2001 From: Suneet Tipirneni <77477100+suneettipirneni@users.noreply.github.com> Date: Wed, 26 Jan 2022 14:27:54 -0500 Subject: [PATCH] refactor: change const enums to regular enums (#306) --- gateway/v8.ts | 8 +++---- gateway/v9.ts | 8 +++---- .../_applicationCommands/_chatInput/shared.ts | 2 +- .../_applicationCommands/permissions.ts | 2 +- .../v8/_interactions/applicationCommands.ts | 2 +- payloads/v8/_interactions/responses.ts | 4 ++-- payloads/v8/application.ts | 2 +- payloads/v8/auditLog.ts | 4 ++-- payloads/v8/channel.ts | 20 ++++++++-------- payloads/v8/gateway.ts | 6 ++--- payloads/v8/guild.ts | 22 ++++++++--------- payloads/v8/guildScheduledEvent.ts | 6 ++--- payloads/v8/invite.ts | 2 +- payloads/v8/oauth2.ts | 2 +- payloads/v8/stageInstance.ts | 2 +- payloads/v8/sticker.ts | 4 ++-- payloads/v8/teams.ts | 2 +- payloads/v8/user.ts | 6 ++--- payloads/v8/webhook.ts | 2 +- .../_applicationCommands/_chatInput/shared.ts | 2 +- .../_applicationCommands/permissions.ts | 2 +- .../v9/_interactions/applicationCommands.ts | 2 +- payloads/v9/_interactions/responses.ts | 4 ++-- payloads/v9/application.ts | 2 +- payloads/v9/auditLog.ts | 4 ++-- payloads/v9/channel.ts | 24 +++++++++---------- payloads/v9/gateway.ts | 6 ++--- payloads/v9/guild.ts | 22 ++++++++--------- payloads/v9/guildScheduledEvent.ts | 6 ++--- payloads/v9/invite.ts | 2 +- payloads/v9/oauth2.ts | 2 +- payloads/v9/stageInstance.ts | 2 +- payloads/v9/sticker.ts | 4 ++-- payloads/v9/teams.ts | 2 +- payloads/v9/user.ts | 6 ++--- payloads/v9/webhook.ts | 2 +- rest/common.ts | 4 ++-- rpc/v8.ts | 4 ++-- rpc/v9.ts | 4 ++-- scripts/deno.mjs | 9 +------ voice/v4.ts | 4 ++-- 41 files changed, 109 insertions(+), 116 deletions(-) diff --git a/gateway/v8.ts b/gateway/v8.ts index af2c8594..27adef2a 100644 --- a/gateway/v8.ts +++ b/gateway/v8.ts @@ -34,7 +34,7 @@ export const GatewayVersion = '8'; /** * https://discord.com/developers/docs/topics/opcodes-and-status-codes#gateway-gateway-opcodes */ -export const enum GatewayOpcodes { +export enum GatewayOpcodes { /** * An event was dispatched */ @@ -85,7 +85,7 @@ export const enum GatewayOpcodes { /** * https://discord.com/developers/docs/topics/opcodes-and-status-codes#gateway-gateway-close-event-codes */ -export const enum GatewayCloseCodes { +export enum GatewayCloseCodes { /** * We're not sure what went wrong. Try reconnecting? */ @@ -168,7 +168,7 @@ export const enum GatewayCloseCodes { /** * https://discord.com/developers/docs/topics/gateway#list-of-intents */ -export const enum GatewayIntentBits { +export enum GatewayIntentBits { Guilds = 1 << 0, GuildMembers = 1 << 1, GuildBans = 1 << 2, @@ -190,7 +190,7 @@ export const enum GatewayIntentBits { /** * https://discord.com/developers/docs/topics/gateway#commands-and-events-gateway-events */ -export const enum GatewayDispatchEvents { +export enum GatewayDispatchEvents { ChannelCreate = 'CHANNEL_CREATE', ChannelDelete = 'CHANNEL_DELETE', ChannelPinsUpdate = 'CHANNEL_PINS_UPDATE', diff --git a/gateway/v9.ts b/gateway/v9.ts index a6b64a65..87a6a579 100644 --- a/gateway/v9.ts +++ b/gateway/v9.ts @@ -37,7 +37,7 @@ export const GatewayVersion = '9'; /** * https://discord.com/developers/docs/topics/opcodes-and-status-codes#gateway-gateway-opcodes */ -export const enum GatewayOpcodes { +export enum GatewayOpcodes { /** * An event was dispatched */ @@ -88,7 +88,7 @@ export const enum GatewayOpcodes { /** * https://discord.com/developers/docs/topics/opcodes-and-status-codes#gateway-gateway-close-event-codes */ -export const enum GatewayCloseCodes { +export enum GatewayCloseCodes { /** * We're not sure what went wrong. Try reconnecting? */ @@ -171,7 +171,7 @@ export const enum GatewayCloseCodes { /** * https://discord.com/developers/docs/topics/gateway#list-of-intents */ -export const enum GatewayIntentBits { +export enum GatewayIntentBits { Guilds = 1 << 0, GuildMembers = 1 << 1, GuildBans = 1 << 2, @@ -193,7 +193,7 @@ export const enum GatewayIntentBits { /** * https://discord.com/developers/docs/topics/gateway#commands-and-events-gateway-events */ -export const enum GatewayDispatchEvents { +export enum GatewayDispatchEvents { ChannelCreate = 'CHANNEL_CREATE', ChannelDelete = 'CHANNEL_DELETE', ChannelPinsUpdate = 'CHANNEL_PINS_UPDATE', diff --git a/payloads/v8/_interactions/_applicationCommands/_chatInput/shared.ts b/payloads/v8/_interactions/_applicationCommands/_chatInput/shared.ts index 12373332..8e2f8213 100644 --- a/payloads/v8/_interactions/_applicationCommands/_chatInput/shared.ts +++ b/payloads/v8/_interactions/_applicationCommands/_chatInput/shared.ts @@ -1,7 +1,7 @@ /** * https://discord.com/developers/docs/interactions/application-commands#application-command-object-application-command-option-type */ -export const enum ApplicationCommandOptionType { +export enum ApplicationCommandOptionType { Subcommand = 1, SubcommandGroup, String, diff --git a/payloads/v8/_interactions/_applicationCommands/permissions.ts b/payloads/v8/_interactions/_applicationCommands/permissions.ts index ca4bbb6b..f8bdfe99 100644 --- a/payloads/v8/_interactions/_applicationCommands/permissions.ts +++ b/payloads/v8/_interactions/_applicationCommands/permissions.ts @@ -43,7 +43,7 @@ export interface APIApplicationCommandPermission { /** * https://discord.com/developers/docs/interactions/application-commands#application-command-permissions-object-application-command-permission-type */ -export const enum ApplicationCommandPermissionType { +export enum ApplicationCommandPermissionType { Role = 1, User, } diff --git a/payloads/v8/_interactions/applicationCommands.ts b/payloads/v8/_interactions/applicationCommands.ts index 98bfd453..aa64512f 100644 --- a/payloads/v8/_interactions/applicationCommands.ts +++ b/payloads/v8/_interactions/applicationCommands.ts @@ -68,7 +68,7 @@ export interface APIApplicationCommand { /** * https://discord.com/developers/docs/interactions/application-commands#application-command-object-application-command-types */ -export const enum ApplicationCommandType { +export enum ApplicationCommandType { ChatInput = 1, User, Message, diff --git a/payloads/v8/_interactions/responses.ts b/payloads/v8/_interactions/responses.ts index 91024ba6..d27cafea 100644 --- a/payloads/v8/_interactions/responses.ts +++ b/payloads/v8/_interactions/responses.ts @@ -5,7 +5,7 @@ import type { APIApplicationCommandOptionChoice } from './applicationCommands'; /** * https://discord.com/developers/docs/interactions/receiving-and-responding#interaction-object-interaction-type */ -export const enum InteractionType { +export enum InteractionType { Ping = 1, ApplicationCommand, MessageComponent, @@ -54,7 +54,7 @@ export interface APIInteractionResponseUpdateMessage { /** * https://discord.com/developers/docs/interactions/receiving-and-responding#interaction-response-object-interaction-callback-type */ -export const enum InteractionResponseType { +export enum InteractionResponseType { /** * ACK a `Ping` */ diff --git a/payloads/v8/application.ts b/payloads/v8/application.ts index 87077a8f..d07b148d 100644 --- a/payloads/v8/application.ts +++ b/payloads/v8/application.ts @@ -96,7 +96,7 @@ export interface APIApplication { /** * https://discord.com/developers/docs/resources/application#application-object-application-flags */ -export const enum ApplicationFlags { +export enum ApplicationFlags { EmbeddedReleased = 1 << 1, ManagedEmoji = 1 << 2, GroupDMCreate = 1 << 4, diff --git a/payloads/v8/auditLog.ts b/payloads/v8/auditLog.ts index f8cfe041..2dda9665 100644 --- a/payloads/v8/auditLog.ts +++ b/payloads/v8/auditLog.ts @@ -104,7 +104,7 @@ export interface APIAuditLogEntry { /** * https://discord.com/developers/docs/resources/audit-log#audit-log-entry-object-audit-log-events */ -export const enum AuditLogEvent { +export enum AuditLogEvent { GuildUpdate = 1, ChannelCreate = 10, @@ -249,7 +249,7 @@ export interface APIAuditLogOptions { role_name?: string; } -export const enum AuditLogOptionsType { +export enum AuditLogOptionsType { Role = '0', Member = '1', } diff --git a/payloads/v8/channel.ts b/payloads/v8/channel.ts index 7aab50f8..f2ca05c5 100644 --- a/payloads/v8/channel.ts +++ b/payloads/v8/channel.ts @@ -180,7 +180,7 @@ export type APIChannel = /** * https://discord.com/developers/docs/resources/channel#channel-object-channel-types */ -export const enum ChannelType { +export enum ChannelType { /** * A text channel within a guild */ @@ -223,7 +223,7 @@ export const enum ChannelType { GuildStageVoice = 13, } -export const enum VideoQualityMode { +export enum VideoQualityMode { /** * Discord chooses the quality for optimal performance */ @@ -425,7 +425,7 @@ export interface APIMessage { /** * https://discord.com/developers/docs/resources/channel#message-object-message-types */ -export const enum MessageType { +export enum MessageType { Default, RecipientAdd, RecipientRemove, @@ -488,7 +488,7 @@ export interface APIMessageReference { /** * https://discord.com/developers/docs/resources/channel#message-object-message-activity-types */ -export const enum MessageActivityType { +export enum MessageActivityType { Join = 1, Spectate, Listen, @@ -498,7 +498,7 @@ export const enum MessageActivityType { /** * https://discord.com/developers/docs/resources/channel#message-object-message-flags */ -export const enum MessageFlags { +export enum MessageFlags { /** * This message has been published to subscribed channels (via Channel Following) */ @@ -595,7 +595,7 @@ export interface APIOverwrite { deny: Permissions; } -export const enum OverwriteType { +export enum OverwriteType { Role, Member, } @@ -688,7 +688,7 @@ export interface APIEmbed { * https://discord.com/developers/docs/resources/channel#embed-object-embed-types * @deprecated *Embed types should be considered deprecated and might be removed in a future API version* */ -export const enum EmbedType { +export enum EmbedType { /** * Generic embed rendered from embed attributes */ @@ -932,7 +932,7 @@ export interface APIChannelMention { /** * https://discord.com/developers/docs/resources/channel#allowed-mentions-object-allowed-mention-types */ -export const enum AllowedMentionsTypes { +export enum AllowedMentionsTypes { /** * Controls @everyone and @here mentions */ @@ -986,7 +986,7 @@ export interface APIBaseMessageComponent { /** * https://discord.com/developers/docs/interactions/message-components#component-types */ -export const enum ComponentType { +export enum ComponentType { /** * Action Row component */ @@ -1070,7 +1070,7 @@ export type APIButtonComponent = APIButtonComponentWithCustomId | APIButtonCompo /** * https://discord.com/developers/docs/interactions/message-components#button-object-button-styles */ -export const enum ButtonStyle { +export enum ButtonStyle { Primary = 1, Secondary, Success, diff --git a/payloads/v8/gateway.ts b/payloads/v8/gateway.ts index f3f03c67..144e0e69 100644 --- a/payloads/v8/gateway.ts +++ b/payloads/v8/gateway.ts @@ -91,7 +91,7 @@ export interface GatewayPresenceUpdate { client_status?: GatewayPresenceClientStatus; } -export const enum PresenceUpdateStatus { +export enum PresenceUpdateStatus { Online = 'online', DoNotDisturb = 'dnd', Idle = 'idle', @@ -216,7 +216,7 @@ export enum ActivityPlatform { /** * https://discord.com/developers/docs/topics/gateway#activity-object-activity-types */ -export const enum ActivityType { +export enum ActivityType { /** * Playing {game} */ @@ -291,7 +291,7 @@ export type GatewayActivitySecrets = Partial { /** * https://discord.com/developers/docs/interactions/message-components#component-types */ -export const enum ComponentType { +export enum ComponentType { /** * Action Row component */ @@ -1239,7 +1239,7 @@ export type APIButtonComponent = APIButtonComponentWithCustomId | APIButtonCompo /** * https://discord.com/developers/docs/interactions/message-components#button-object-button-styles */ -export const enum ButtonStyle { +export enum ButtonStyle { Primary = 1, Secondary, Success, diff --git a/payloads/v9/gateway.ts b/payloads/v9/gateway.ts index 4a85be63..2ab8ce7f 100644 --- a/payloads/v9/gateway.ts +++ b/payloads/v9/gateway.ts @@ -92,7 +92,7 @@ export interface GatewayPresenceUpdate { client_status?: GatewayPresenceClientStatus; } -export const enum PresenceUpdateStatus { +export enum PresenceUpdateStatus { Online = 'online', DoNotDisturb = 'dnd', Idle = 'idle', @@ -217,7 +217,7 @@ export enum ActivityPlatform { /** * https://discord.com/developers/docs/topics/gateway#activity-object-activity-types */ -export const enum ActivityType { +export enum ActivityType { /** * Playing {game} */ @@ -292,7 +292,7 @@ export type GatewayActivitySecrets = Partial